Skip to content

Conversation

@ezaquarii
Copy link
Collaborator

@ezaquarii ezaquarii commented Jun 16, 2019

  1. Bitmap decoder does not work with vector drawables directly
  2. Dependency injection in PreviewMediaFragment

Fixes #4121
Fixes #4129
Fixes #4150

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

@ezaquarii
Copy link
Collaborator Author

@AndyScherzinger @tobiasKaminsky This should go to 3.7.0

1) Bitmap decoder does not work with vector drawables directly
2) Dependency injection in PreviewMediaFragment

Fixes #4121
Fixes #4129
Fixes #4150

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@ezaquarii ezaquarii force-pushed the ezaquarii/fix-crash-when-playing-video branch from c2a8706 to 38c7605 Compare June 16, 2019 15:01
@ezaquarii ezaquarii changed the title Fix dependency injection in PreviewMediaFragment Fix crash when displaying video files Jun 16, 2019
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9757.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

306

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

@ezaquarii ezaquarii added this to the Nextcloud App 3.7.0 milestone Jun 16, 2019
@AndyScherzinger
Copy link
Member

/backport to stable-3.7

@backportbot-nextcloud
Copy link

backport to stable-3.7 in #4167

@AndyScherzinger AndyScherzinger deleted the ezaquarii/fix-crash-when-playing-video branch June 20, 2019 14:29
tobiasKaminsky added a commit that referenced this pull request Jun 21, 2019
b545881 Merge pull request #4156 from nextcloud/ezaquarii/fix-crash-when-playing-video
f49fcf0 Merge pull request #4164 from nextcloud/dependabot/gradle/kotlin_version-1.3.40
7196202 Bump kotlin_version from 1.3.31 to 1.3.40
abead1d Merge pull request #4166 from nextcloud/dependabot/gradle/com.google.dagger-dagger-2.23.2
8169f31 Bump dagger
65d1321 Bump dagger from 2.23.1 to 2.23.2
e28f4d4 Merge pull request #4158 from nextcloud/dependabot/gradle/com.mebigfatguy.fb-contrib-fb-contrib-7.4.6
a4c4932 [tx-robot] updated from transifex
34d0c95 [tx-robot] updated from transifex
1f76a79 daily dev 20190619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crash on startup (something with thumbnails) App crashes upon start. mp4 access crashes latest dev App

4 participants