Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #4156

1) Bitmap decoder does not work with vector drawables directly
2) Dependency injection in PreviewMediaFragment

Fixes #4121
Fixes #4129
Fixes #4150

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9782.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.7PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings47
Dodgy code Warnings137
Total421

SpotBugs (stable-3.7)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings47
Dodgy code Warnings137
Total421

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #4167 into stable-3.7 will increase coverage by 0.07%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             stable-3.7    #4167      +/-   ##
================================================
+ Coverage         14.34%   14.42%   +0.07%     
  Complexity            1        1              
================================================
  Files               331      331              
  Lines             31103    31104       +1     
  Branches           4434     4434              
================================================
+ Hits               4462     4486      +24     
+ Misses            25853    25830      -23     
  Partials            788      788
Impacted Files Coverage Δ Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/preview/PreviewMediaFragment.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 33.33% <0%> (-0.07%) 0 <0> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 20.22% <0%> (-0.38%) 0% <0%> (ø)
...loud/android/datamodel/FileDataStorageManager.java 36.04% <0%> (+0.31%) 0% <0%> (ø) ⬇️
...oud/android/operations/RefreshFolderOperation.java 55.7% <0%> (+6.57%) 0% <0%> (ø) ⬇️
...owncloud/android/ui/adapter/DiskLruImageCache.java 38.96% <0%> (+7.79%) 0% <0%> (ø) ⬇️

@AndyScherzinger AndyScherzinger merged commit 30eb438 into stable-3.7 Jun 20, 2019
@AndyScherzinger AndyScherzinger deleted the backport/4156/stable-3.7 branch June 20, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants