Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 20, 2019

Bumps dagger from 2.23.1 to 2.23.2.

Release notes

Sourced from dagger's releases.

Dagger 2.23.2

In addition to the 2.23.1 release notes, this release:

  • Fixes a bug where an @Inject method has a parameter name that is valid on the JVM but invalid for the Java language (and can come up in some cases in Kotlin: a11605cfa56ad944892ef34fc19ac8dd64a9e89e)
  • Suppresses all unchecked/rawtypes warnings in Dagger generated code (ce23333d6a84ef0b62b43da1c63d905047d06258)
Commits
  • ce28396 2.23.2 release
  • abf0144 Fix grammar.
  • 9e35c93 @​Binds methods have no need to use exceptions, since they don't have method b...
  • ce23333 Suppress unchecked+rawtypes warnings on all Dagger generated code.
  • adfa71d Https everywhere
  • 5bab131 Extend raw Subject instead of supplying type parameters.
  • c9a46c9 Reduce usages of ResolvedBindings as much as possible.
  • a11605c Fix a bug where an @​Inject method has a parameter name that is valid on the J...
  • c4775c1 Remove unused parameter
  • 257887c Remove unnecessary "manifest = ..." entries from @​Config annotations.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Jun 20, 2019
Bumps [dagger](https://github.com/google/dagger) from 2.23.1 to 2.23.2.
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.23.1...dagger-2.23.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/com.google.dagger-dagger-2.23.2 branch from 8b9c31a to 65d1321 Compare June 20, 2019 10:46
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9777.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

306

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

@AndyScherzinger AndyScherzinger merged commit abead1d into master Jun 20, 2019
@AndyScherzinger AndyScherzinger deleted the dependabot/gradle/com.google.dagger-dagger-2.23.2 branch June 20, 2019 14:05
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Jun 20, 2019
tobiasKaminsky added a commit that referenced this pull request Jun 21, 2019
b545881 Merge pull request #4156 from nextcloud/ezaquarii/fix-crash-when-playing-video
f49fcf0 Merge pull request #4164 from nextcloud/dependabot/gradle/kotlin_version-1.3.40
7196202 Bump kotlin_version from 1.3.31 to 1.3.40
abead1d Merge pull request #4166 from nextcloud/dependabot/gradle/com.google.dagger-dagger-2.23.2
8169f31 Bump dagger
65d1321 Bump dagger from 2.23.1 to 2.23.2
e28f4d4 Merge pull request #4158 from nextcloud/dependabot/gradle/com.mebigfatguy.fb-contrib-fb-contrib-7.4.6
a4c4932 [tx-robot] updated from transifex
34d0c95 [tx-robot] updated from transifex
1f76a79 daily dev 20190619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants