Master: get lint/warnings down

scripts/analysis/findbugs-results.txt

@@ -1 +1 @@
-422
+423

src/androidTest/java/com/owncloud/android/datamodel/OCFileUnitTest.java

@@ -37,7 +37,7 @@
  * Instrumented unit test, to be run in an Android emulator or device.
  *
  * At the moment, it's a sample to validate the automatic test environment, in the scope of instrumented unit tests.
- *
+ *vvlcvlc
  * Don't take it as an example of completeness.
  *
  * See http://developer.android.com/intl/es/training/testing/unit-testing/instrumented-unit-tests.html .

src/main/java/com/nextcloud/client/onboarding/OnboardingServiceImpl.kt

@@ -22,7 +22,6 @@ import android.app.Activity
 import android.content.Context
 import android.content.Intent
 import android.content.res.Resources
-
 import com.nextcloud.client.account.CurrentAccountProvider
 import com.nextcloud.client.preferences.AppPreferences
 import com.owncloud.android.BuildConfig
@@ -41,9 +40,10 @@ internal class OnboardingServiceImpl constructor(
         const val ITEM_VERSION_CODE = 99999999
     }
 
-    private val notSeenYet: Boolean get() {
-        return BuildConfig.VERSION_CODE >= ITEM_VERSION_CODE && preferences.lastSeenVersionCode < ITEM_VERSION_CODE
-    }
+    private val notSeenYet: Boolean
+        get() {
+            return BuildConfig.VERSION_CODE >= ITEM_VERSION_CODE && preferences.lastSeenVersionCode < ITEM_VERSION_CODE
+        }
 
     override val whatsNew: Array<FeatureItem>
         get() = if (!isFirstRun && notSeenYet) {

src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java

@@ -86,7 +86,6 @@
 import com.owncloud.android.ui.events.AccountRemovedEvent;
 import com.owncloud.android.ui.events.ChangeMenuEvent;
 import com.owncloud.android.ui.events.DummyDrawerEvent;
-import com.owncloud.android.ui.events.MenuItemClickEvent;
 import com.owncloud.android.ui.events.SearchEvent;
 import com.owncloud.android.ui.fragment.OCFileListFragment;
 import com.owncloud.android.ui.trashbin.TrashbinActivity;
@@ -385,23 +384,6 @@ private void filterDrawerMenu(Menu menu, Account account) {
         DrawerMenuUtil.removeMenuItem(menu, R.id.nav_logout, !getResources().getBoolean(R.bool.show_drawer_logout));
     }
 
-    @Subscribe(threadMode = ThreadMode.MAIN)
-    public void onMessageEvent(MenuItemClickEvent event) {
-        unsetAllDrawerMenuItems();
-
-        switch (event.menuItem.getItemId()) {
-            case R.id.nav_bar_files:
-                showFiles(false);
-                break;
-            case R.id.nav_bar_settings:
-                Intent settingsIntent = new Intent(getApplicationContext(), SettingsActivity.class);
-                startActivity(settingsIntent);
-                break;
-            default:
-                break;
-        }
-    }
-
     @Subscribe(threadMode = ThreadMode.MAIN)
     public void onMessageEvent(DummyDrawerEvent event) {
         unsetAllDrawerMenuItems();

src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java

@@ -45,7 +45,6 @@
 import android.view.ViewGroup;
 import android.widget.AbsListView;
 import android.widget.PopupMenu;
-import android.widget.RelativeLayout;
 
 import com.google.android.material.snackbar.Snackbar;
 import com.nextcloud.client.account.UserAccountManager;
@@ -279,17 +278,6 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
             currentSearchType = SearchType.NO_SEARCH;
         }
 
-        if (savedInstanceState != null) {
-            final View fabView = v.findViewById(R.id.fab_main);
-            final RelativeLayout.LayoutParams layoutParams = (RelativeLayout.LayoutParams)
-                    fabView.getLayoutParams();
-            layoutParams.addRule(RelativeLayout.ALIGN_PARENT_BOTTOM, 1);
-            new Handler().post(() -> {
-                fabView.setLayoutParams(layoutParams);
-                fabView.invalidate();
-            });
-        }
-
         Bundle args = getArguments();
         boolean allowContextualActions = args != null && args.getBoolean(ARG_ALLOW_CONTEXTUAL_ACTIONS, false);
         if (allowContextualActions) {

src/main/res/values/strings.xml

@@ -27,7 +27,6 @@
     <string name="drawer_item_recently_modified">Recently modified</string>
     <string name="drawer_item_shared">Shared</string>
     <string name="drawer_item_videos">Videos</string>
-    <string name="drawer_item_settings">Settings</string>
     <string name="drawer_item_uploads_list">Uploads</string>
     <string name="drawer_item_activities">Activities</string>
     <string name="drawer_item_notifications">Notifications</string>

src/test/java/com/nextcloud/client/device/TestPowerManagementService.kt

@@ -26,7 +26,13 @@ import android.content.Intent
 import android.os.BatteryManager
 import android.os.Build
 import android.os.PowerManager
-import com.nhaarman.mockitokotlin2.*
+import com.nhaarman.mockitokotlin2.any
+import com.nhaarman.mockitokotlin2.anyOrNull
+import com.nhaarman.mockitokotlin2.eq
+import com.nhaarman.mockitokotlin2.mock
+import com.nhaarman.mockitokotlin2.never
+import com.nhaarman.mockitokotlin2.verify
+import com.nhaarman.mockitokotlin2.whenever
 import org.junit.Assert.assertFalse
 import org.junit.Assert.assertTrue
 import org.junit.Before