Master: get lint/warnings down

[tobiasKaminsky]

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[AndyScherzinger]

👍

[tobiasKaminsky]

:-D
I could have expected that you directly see this PR.
I just changed something so that our "check if drone needs to be run" is allowing drone.
Now we will get lint/kotlin error/increased warnings.
Then I can fix them :-)

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10045.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

281

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	70
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	136
Total	423

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	70
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	136
Total	423

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@a1477a1). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4253   +/-   ##
=========================================
  Coverage          ?   14.32%           
  Complexity        ?        1           
=========================================
  Files             ?      331           
  Lines             ?    31029           
  Branches          ?     4405           
=========================================
  Hits              ?     4446           
  Misses            ?    25801           
  Partials          ?      782

Impacted Files	Coverage Δ	Complexity Δ
...m/owncloud/android/ui/activity/DrawerActivity.java	40.19% <ø> (ø)	0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java	19.04% <ø> (ø)	0 <0> (?)
...xtcloud/client/onboarding/OnboardingServiceImpl.kt	16.66% <0%> (ø)	0 <0> (?)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@a1477a1). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4253   +/-   ##
=========================================
  Coverage          ?   14.32%           
  Complexity        ?        1           
=========================================
  Files             ?      331           
  Lines             ?    31029           
  Branches          ?     4405           
=========================================
  Hits              ?     4446           
  Misses            ?    25801           
  Partials          ?      782

Impacted Files	Coverage Δ	Complexity Δ
...m/owncloud/android/ui/activity/DrawerActivity.java	40.19% <ø> (ø)	0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java	19.04% <ø> (ø)	0 <0> (?)
...xtcloud/client/onboarding/OnboardingServiceImpl.kt	16.66% <0%> (ø)	0 <0> (?)

[tobiasKaminsky]

All green now.
This came from the problem of "check if drone should run" which was doing false positive.

[tobiasKaminsky]

I wanted to rebase/squash this, as commit history looks awful.
Note to myself: better do it directly ;-)