Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Found by @nickvergessen, 🎉

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10049.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

281

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a65d1dd). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4254   +/-   ##
=========================================
  Coverage          ?   14.31%           
  Complexity        ?        1           
=========================================
  Files             ?      331           
  Lines             ?    31030           
  Branches          ?     4405           
=========================================
  Hits              ?     4443           
  Misses            ?    25805           
  Partials          ?      782
Impacted Files Coverage Δ Complexity Δ
.../android/authentication/AuthenticatorActivity.java 1.88% <0%> (ø) 0 <0> (?)

1 similar comment
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a65d1dd). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4254   +/-   ##
=========================================
  Coverage          ?   14.31%           
  Complexity        ?        1           
=========================================
  Files             ?      331           
  Lines             ?    31030           
  Branches          ?     4405           
=========================================
  Hits              ?     4443           
  Misses            ?    25805           
  Partials          ?      782
Impacted Files Coverage Δ Complexity Δ
.../android/authentication/AuthenticatorActivity.java 1.88% <0%> (ø) 0 <0> (?)

@AndyScherzinger AndyScherzinger merged commit 5370493 into master Jul 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the clearInputBeforeQR branch July 23, 2019 13:12
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Jul 23, 2019
tobiasKaminsky added a commit that referenced this pull request Jul 24, 2019
5370493 Merge pull request #4254 from nextcloud/clearInputBeforeQR
011169d reset host when using login via QR/link
a65d1dd Merge pull request #4253 from nextcloud/fixMaster
e9b0684 remove leftover
6a925b7 wip
fc01e97 wip
ac3a6d5 reformat imports kotlin: do not use wildcard imports
4c5eca9 remove leftovers from bottom bar removing
040b460 show "shared" again (#4249)
1064463 Bump ktlint from 0.34.0 to 0.34.1 (#4252)
eb68c36 wip
a1477a1 daily dev 20190723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants