Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jul 26, 2019

Introdced in #4254

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10108.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

281

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #4270 into master will decrease coverage by 2.65%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4270      +/-   ##
============================================
- Coverage      14.3%   11.64%   -2.66%     
  Complexity        1        1              
============================================
  Files           331      331              
  Lines         31030    31033       +3     
  Branches       4405     4406       +1     
============================================
- Hits           4439     3615     -824     
- Misses        25810    26795     +985     
+ Partials        781      623     -158
Impacted Files Coverage Δ Complexity Δ
.../android/authentication/AuthenticatorActivity.java 1.88% <0%> (-0.01%) 0 <0> (ø)
...ud/android/operations/GetUserProfileOperation.java 0% <0%> (-88.89%) 0% <0%> (ø)
...ava/com/owncloud/android/utils/DataHolderUtil.java 0% <0%> (-82.36%) 0% <0%> (ø)
...d/android/operations/UpdateOCVersionOperation.java 0% <0%> (-55.82%) 0% <0%> (ø)
...cloud/android/datamodel/ArbitraryDataProvider.java 11.53% <0%> (-51.29%) 0% <0%> (ø)
...d/android/operations/GetCapabilitiesOperation.java 25% <0%> (-50%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 2.19% <0%> (-46.93%) 0% <0%> (ø)
...owncloud/android/ui/adapter/DiskLruImageCache.java 0% <0%> (-30%) 0% <0%> (ø)
...loud/android/datamodel/FileDataStorageManager.java 13.15% <0%> (-22.57%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 12.21% <0%> (-16.22%) 0% <0%> (ø)
... and 18 more

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Jul 26, 2019
@tobiasKaminsky tobiasKaminsky merged commit 0938d81 into master Jul 29, 2019
@tobiasKaminsky tobiasKaminsky deleted the npeInNClogin branch July 29, 2019 09:28
tobiasKaminsky added a commit that referenced this pull request Jul 30, 2019
129e9ab Merge pull request #4276 from nextcloud/uploader
bc0b9e7 Engineering Test Mode (#4133)
a6371ee check status on transfer update
0938d81 mHostUrlInput can be null if used with direct login (#4270)
53a4844 Merge pull request #4269 from nextcloud/daggerBump
4632dc6 [tx-robot] updated from transifex
2124364 daily dev 20190727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants