Engineering Test Mode

[ezaquarii]

If you are wondering where ETM (Engineering Test Mode) term came from, it's automotive industry. If you have a car, you can probably play with it there too. :)

This module allows developers and dev users to access some internal application data.
The module is indended to be a dumping ground for various diagnostic and development tools.

1. Go to Settings
2. Scroll to section "Dev" (bottom)
3. Select "Engineering Test Mode"

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

[ezaquarii]

@tobiasKaminsky @AndyScherzinger I created this PR to help a user with #3421 that was unable to share relevant diagnostics with us.

Please review and comment. It's WIP as I don't want to invest more time into it before we make sure it's worth it.

[christianlupus]

@ezaquarii Now things are gettign strange. The app is installed parallel to the main app. With the QA version, I can open the app without swipe code even if I set it up like this in the settings.I tried to quit the app by going into the task manager and there swiping out the app. Still the app opens directly without protection, content is shown in the task switcher and I can make screenshots.

So unfortunately this branch is not working as intended as a debug tool....

[ezaquarii]

@christianlupus You are right that this "QA" version is installed as a separate app. QA versions are intended for evaluation without overwriting your daily-driver app, especially that it might not work or cause data corruption. This way your data is safe and the experiment is done in a "sandbox".

Regarding the locking mechanism - you have probably found another bug. We'll be investigating it when @tobiasKaminsky comes back.

[ezaquarii]

@tobiasKaminsky Let me know what you think about it - I don't want to invest more time into it if it's a bad idea. (-:

[tobiasKaminsky]

@tobiasKaminsky Let me know what you think about it - I don't want to invest more time into it if it's a bad idea. (-:

If we put this for now only on dev/daily version, I am fine with it.
So if an user experiences a bug where we need more infos, we can ask him to test dev version (which then is based on master, where the problem is maybe already fixed) and additional can ask them for infos via ETM.

Big question would be, which infos do we want to have collected…

[ezaquarii]

Big question would be, which infos do we want to have collected…

Well, when you browse the backlog of bugs, it is quite clear that we're lacking audit capabilities as there is no way of getting meaningful data from users currently. My intention was to create a dumping ground for such tools, as I needed to investigate preferences relevant to #3421 and there was no tool to do it.

I'm sure the tech support would love to have it.

Quite frankly, if you could reach them and ask them for feature requests, that would be great. I'm sure they are having tons of interesting stories to tell...

[tobiasKaminsky]

Please see inline comments

[codecov]

Codecov Report

Merging #4133 into master will decrease coverage by <.01%.
The diff coverage is 15.87%.

@@             Coverage Diff              @@
##             master    #4133      +/-   ##
============================================
- Coverage     14.33%   14.32%   -0.01%     
  Complexity        1        1              
============================================
  Files           331      340       +9     
  Lines         31030    31156     +126     
  Branches       4405     4423      +18     
============================================
+ Hits           4447     4462      +15     
- Misses        25801    25909     +108     
- Partials        782      785       +3

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0% <ø> (ø)	0 <0> (ø)	⬇️
src/main/java/com/owncloud/android/MainApp.java	54.7% <ø> (ø)	0 <0> (ø)	⬇️
.../main/java/com/nextcloud/client/etm/EtmActivity.kt	0% <0%> (ø)	0 <0> (?)
...n/java/com/nextcloud/client/etm/EtmMenuFragment.kt	0% <0%> (ø)	0 <0> (?)
...n/java/com/nextcloud/client/etm/EtmBaseFragment.kt	0% <0%> (ø)	0 <0> (?)
...owncloud/android/ui/activity/SettingsActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...in/java/com/nextcloud/client/etm/EtmMenuAdapter.kt	0% <0%> (ø)	0 <0> (?)
...xtcloud/client/etm/pages/EtmPreferencesFragment.kt	0% <0%> (ø)	0 <0> (?)
...n/java/com/nextcloud/client/di/ViewModelFactory.kt	0% <0%> (ø)	0 <0> (?)
...in/java/com/nextcloud/client/di/ViewModelModule.kt	0% <0%> (ø)	0 <0> (?)
... and 14 more

[AndyScherzinger]

@tobiasKaminsky can you re-review. Imho all review commetns have been fixed, I just optimized one padding value for toolbar text alignment, so this is imho ready to be merged now 👍

Nice work @ezaquarii - as always 🎉

[AndyScherzinger]

All things turned green, just waiting for @tobiasKaminsky's final approval :)

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10088.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

281

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	70
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	136
Total	423

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	70
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	136
Total	423

[ezaquarii]

@tobiasKaminsky ping!

[tobiasKaminsky]

Can you rename this to etm_layout.xml?
Then we have this in sync to all other names.

[tobiasKaminsky]

Maybe etm_fragment_menu? So that etm is in front

[tobiasKaminsky]

Same here, etm in front?

[tobiasKaminsky]

Just litte naming ideas: have ETM in front of activity/fragment.
Other than that 👍 👍

As always thank very very much for your valuable contributions!

[AndyScherzinger]

@tobiasKaminsky I am with @ezaquarii's actual file names, se for example:

• https://medium.com/mindorks/android-resource-naming-convention-42e4e8026614
• https://github.com/ribot/android-guidelines/blob/master/project_and_code_guidelines.md

So files should start with the "type" So I think, this should be merged as-is.

[tobiasKaminsky]

I was just looking at our current naming scheme, e.g:
activity_list_item.xml
contactlist_fragment.xml
file_details_fragment.xml

I am totally up for changing this. I just do not want that we have different naming schemes…
I guess we could also have subfolders in layout to split up activity, fragment, etc.

[AndyScherzinger]

I am totally up for changing this. I just do not want that we have different naming schemes…

absolutely, yes

I guess we could also have subfolders in layout to split up activity, fragment, etc.

I don't think Android is support sub-folders with the layout structure!

[AndyScherzinger]

@tobiasKaminsky opened #4278 for discussion of naming pattern(s) - I'd still vote to simply merge it (or rename and merge, but not further postpone the merge)

[tobiasKaminsky]

As we will go with new naming scheme, we can merge this.