combined dagger bump

[tobiasKaminsky]

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[AndyScherzinger]

Build is failing ❗️

[tobiasKaminsky]

https://github.com/google/dagger/releases/tag/dagger-2.24

@ezaquarii so they removed the individual implementation, but only use HasAndroidInjector now.
But I fail to change this…

[ezaquarii]

@tobiasKaminsky @AndyScherzinger Dagger migration is done.

[AndyScherzinger]

I am afk but can give it a spin next week. 👍

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10110.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

281

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	70
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	136
Total	423

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	70
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	136
Total	423

[codecov]

Codecov Report

Merging #4269 into master will decrease coverage by 0.54%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4269      +/-   ##
============================================
- Coverage      14.3%   13.76%   -0.55%     
  Complexity        1        1              
============================================
  Files           331      331              
  Lines         31030    31028       -2     
  Branches       4405     4405              
============================================
- Hits           4439     4270     -169     
- Misses        25810    26036     +226     
+ Partials        781      722      -59

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/com/owncloud/android/MainApp.java	54.41% <100%> (-0.29%)	0 <0> (ø)
...ava/com/owncloud/android/utils/DataHolderUtil.java	58.82% <0%> (-23.53%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	12.21% <0%> (-16.22%)	0% <0%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java	47.05% <0%> (-8.83%)	0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java	78.26% <0%> (-4.35%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	28.86% <0%> (-4.23%)	0% <0%> (ø)
...ava/com/owncloud/android/utils/DrawerMenuUtil.java	42.42% <0%> (-3.04%)	0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java	47% <0%> (-2.14%)	0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	16.99% <0%> (-1.87%)	0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java	62.38% <0%> (-1.84%)	0% <0%> (ø)
... and 7 more

[codecov]

Codecov Report

Merging #4269 into master will decrease coverage by 0.54%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4269      +/-   ##
============================================
- Coverage      14.3%   13.76%   -0.55%     
  Complexity        1        1              
============================================
  Files           331      331              
  Lines         31030    31028       -2     
  Branches       4405     4405              
============================================
- Hits           4439     4270     -169     
- Misses        25810    26036     +226     
+ Partials        781      722      -59

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/com/owncloud/android/MainApp.java	54.41% <100%> (-0.29%)	0 <0> (ø)
...ava/com/owncloud/android/utils/DataHolderUtil.java	58.82% <0%> (-23.53%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	12.21% <0%> (-16.22%)	0% <0%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java	47.05% <0%> (-8.83%)	0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java	78.26% <0%> (-4.35%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	28.86% <0%> (-4.23%)	0% <0%> (ø)
...ava/com/owncloud/android/utils/DrawerMenuUtil.java	42.42% <0%> (-3.04%)	0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java	47% <0%> (-2.14%)	0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	16.99% <0%> (-1.87%)	0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java	62.38% <0%> (-1.84%)	0% <0%> (ø)
... and 7 more

[AndyScherzinger]

👍 Works fine for me 👍

[tobiasKaminsky]

Tested & works.
@ezaquarii thanks for fixing it. I tried nearly the same, but for an unknown reason it did not worked.