Skip to content

Check status on transfer update #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Jul 29, 2019
Merged

Check status on transfer update #4276

AndyScherzinger merged 1 commit into from
Jul 29, 2019

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jul 29, 2019

Previously if boundListener was null, no check was performed.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

AndyScherzinger
AndyScherzinger reviewed Jul 29, 2019
View reviewed changes
src/main/java/com/owncloud/android/files/services/FileUploader.java Outdated
private static final String UPLOADS_ADDED_MESSAGE = "UPLOADS_ADDED";
private static final String UPLOAD_START_MESSAGE = "UPLOAD_START";
private static final String UPLOAD_FINISH_MESSAGE = "UPLOAD_FINISH";
private static final String UPLOAD_FINISH_MESSAGE = "UPLOAD_FINSH";
Copy link
Member

@AndyScherzinger AndyScherzinger Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky Is this correct?

Copy link
Member Author

@tobiasKaminsky tobiasKaminsky Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well…I have no idea how and when I changed this.
It is of course not correct…

@tobiasKaminsky
check status on transfer update
a6371ee 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jul 29, 2019

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10133.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jul 29, 2019

Codacy

281

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4276 into master will decrease coverage by 0.54%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #4276      +/-   ##
===========================================
- Coverage     14.34%   13.8%   -0.55%     
  Complexity        1       1              
===========================================
  Files           331     331              
  Lines         31029   31029              
  Branches       4406    4406              
===========================================
- Hits           4451    4283     -168     
- Misses        25797   26025     +228     
+ Partials        781     721      -60
Impacted Files Coverage Δ Complexity Δ
.../owncloud/android/files/services/FileUploader.java 9.62% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/owncloud/android/utils/DataHolderUtil.java 58.82% <0%> (-23.53%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 12.21% <0%> (-16.22%) 0% <0%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java 47.05% <0%> (-8.83%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 28.86% <0%> (-5.7%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java 78.26% <0%> (-4.35%) 0% <0%> (ø)
.../owncloud/android/ui/activity/ToolbarActivity.java 56.52% <0%> (-2.9%) 0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java 62.38% <0%> (-1.84%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 17.15% <0%> (-1.78%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 49.14% <0%> (-1.71%) 0% <0%> (ø)
... and 5 more

1 similar comment
@codecov
Copy link

codecov bot commented Jul 29, 2019 •
edited
Loading

Codecov Report

Merging #4276 into master will decrease coverage by 0.54%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #4276      +/-   ##
===========================================
- Coverage     14.34%   13.8%   -0.55%     
  Complexity        1       1              
===========================================
  Files           331     331              
  Lines         31029   31029              
  Branches       4406    4406              
===========================================
- Hits           4451    4283     -168     
- Misses        25797   26025     +228     
+ Partials        781     721      -60
Impacted Files Coverage Δ Complexity Δ
.../owncloud/android/files/services/FileUploader.java 9.62% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/owncloud/android/utils/DataHolderUtil.java 58.82% <0%> (-23.53%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 12.21% <0%> (-16.22%) 0% <0%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java 47.05% <0%> (-8.83%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 28.86% <0%> (-5.7%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java 78.26% <0%> (-4.35%) 0% <0%> (ø)
.../owncloud/android/ui/activity/ToolbarActivity.java 56.52% <0%> (-2.9%) 0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java 62.38% <0%> (-1.84%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 17.15% <0%> (-1.78%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 49.14% <0%> (-1.71%) 0% <0%> (ø)
... and 5 more

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jul 29, 2019

@tobiasKaminsky ready, steady, merge?

@AndyScherzinger AndyScherzinger merged commit 129e9ab into master Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the uploader branch July 29, 2019 13:35
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Jul 29, 2019
tobiasKaminsky added a commit that referenced this pull request Jul 30, 2019
@tobiasKaminsky
daily dev 20190730
84e3629 
129e9ab Merge pull request #4276 from nextcloud/uploader
bc0b9e7 Engineering Test Mode (#4133)
a6371ee check status on transfer update
0938d81 mHostUrlInput can be null if used with direct login (#4270)
53a4844 Merge pull request #4269 from nextcloud/daggerBump
4632dc6 [tx-robot] updated from transifex
2124364 daily dev 20190727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger