Show username in full account name

[ezaquarii]

Fixes #4337

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

[ezaquarii]

Is that what we'd like to have? I can understand if we don't want to share the username in drawer for security reasons.

[codecov]

Codecov Report

Merging #4338 into master will decrease coverage by 0.03%.
The diff coverage is 25%.

@@             Coverage Diff              @@
##             master    #4338      +/-   ##
============================================
- Coverage     16.82%   16.79%   -0.04%     
  Complexity        1        1              
============================================
  Files           354      354              
  Lines         31509    31511       +2     
  Branches       4474     4474              
============================================
- Hits           5302     5292      -10     
- Misses        25320    25333      +13     
+ Partials        887      886       -1

Impacted Files	Coverage Δ	Complexity Δ
.../java/com/owncloud/android/utils/DisplayUtils.java	20.67% <25%> (-2.31%)	0 <0> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java	50.21% <0%> (-1.69%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	80.95% <0%> (-1.2%)	0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java	24.73% <0%> (-0.4%)	0% <0%> (ø)
...ain/java/com/nextcloud/client/logger/LoggerImpl.kt	89.39% <0%> (+3.03%)	0% <0%> (ø)	⬇️
...com/nextcloud/client/logger/LegacyLoggerAdapter.kt	77.77% <0%> (+11.11%)	0% <0%> (ø)	⬇️

[codecov]

Codecov Report

Merging #4338 into master will decrease coverage by 0.72%.
The diff coverage is 25%.

@@             Coverage Diff              @@
##             master    #4338      +/-   ##
============================================
- Coverage     17.94%   17.22%   -0.73%     
  Complexity        1        1              
============================================
  Files           356      354       -2     
  Lines         33339    32520     -819     
  Branches       5022     4777     -245     
============================================
- Hits           5984     5601     -383     
+ Misses        26351    25986     -365     
+ Partials       1004      933      -71

Impacted Files	Coverage Δ	Complexity Δ
.../java/com/owncloud/android/utils/DisplayUtils.java	20.67% <25%> (-2.31%)	0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java	46.09% <0%> (-5.06%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	31.51% <0%> (-4.17%)	0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java	24.73% <0%> (-3.62%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (-1.2%)	0% <0%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java	61.76% <0%> (-1.1%)	0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	22.94% <0%> (-0.62%)	0% <0%> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java	55.92% <0%> (-0.33%)	0% <0%> (ø)
...roid/ui/activity/ReceiveExternalFilesActivity.java	0% <0%> (ø)	0% <0%> (ø)	⬇️
... and 12 more

[nextcloud-android-bot]

Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10440

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10466.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

276

Lint

Type	master	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	111
Security Warnings	46
Dodgy code Warnings	135
Total	410

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	111
Security Warnings	46
Dodgy code Warnings	135
Total	410

[tobiasKaminsky]

Closing in favor of #4355 which was discussed in #4337