Upload files into subfolder

[tobiasKaminsky]

Fix #4375

This uploads file in corresponding subfolder, and creates it.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[AndyScherzinger]

Something went very wrong with Spotbugs...?!

[rullzer]

The test APK fied the issue for me :)

[codecov]

Codecov Report

Merging #4425 into master will increase coverage by 0.04%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #4425      +/-   ##
============================================
+ Coverage     17.24%   17.29%   +0.04%     
  Complexity        3        3              
============================================
  Files           373      373              
  Lines         32076    32079       +3     
  Branches       4538     4538              
============================================
+ Hits           5533     5547      +14     
+ Misses        25643    25632      -11     
  Partials        900      900

Impacted Files	Coverage Δ	Complexity Δ
...ncloud/android/datamodel/SyncedFolderProvider.java	11.2% <ø> (ø)	0 <0> (ø)	⬇️
...n/java/com/owncloud/android/jobs/FilesSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java	25.36% <100%> (ø)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java	50% <0%> (-1.58%)	0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java	24.47% <0%> (-0.43%)	0% <0%> (ø)
...loud/android/datamodel/FileDataStorageManager.java	36.5% <0%> (-0.08%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	29.82% <0%> (+0.19%)	0% <0%> (ø)	⬇️
...owncloud/android/ui/activity/SettingsActivity.java	38.75% <0%> (+0.2%)	0% <0%> (ø)	⬇️
...cloud/android/ui/activity/FileDisplayActivity.java	20.17% <0%> (+0.48%)	0% <0%> (ø)	⬇️
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (+1.19%)	0% <0%> (ø)	⬇️
... and 3 more

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11040.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

499

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	139
Total	427

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	139
Total	427

[AndyScherzinger]

/backport to stable-3.8

[backportbot-nextcloud]

The backport to stable-3.8 failed. Please do this backport manually.

[AndyScherzinger]

@tobiasKaminsky can you do a manual backport (IMHO we should just backport any fix except for very large ones)

[erikkroes]

Can this be merged please? Would mean a lot if it could!

[AndyScherzinger]

@erikkroes this PR has been merged last year in October! Shipped with 3.9.0

[erikkroes]

Ah, sorry for the confusion. I must have some updating to do then.