Normalize local target path in auto upload #4470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes nextcloud#2131 and closes nextcloud#4220.
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Codecov Report
@@ Coverage Diff @@
## master #4470 +/- ##
===========================================
+ Coverage 16.98% 17% +0.01%
Complexity 3 3
===========================================
Files 364 364
Lines 32065 32065
Branches 4515 4515
===========================================
+ Hits 5446 5452 +6
+ Misses 25724 25722 -2
+ Partials 895 891 -4
|
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Member
|
@stephanritscher thank you for this finding! 🎉 I also added some test cases, only for this function. |
tobiasKaminsky
approved these changes
Oct 1, 2019
Member
|
/backport to stable-3.8 |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11036.apk |
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11036 |
|
backport to stable-3.8 in #4587 |
tobiasKaminsky
added a commit
that referenced
this pull request
Oct 2, 2019
ea696c5 Merge pull request #4425 from nextcloud/autoUploadSubfolder 37c6600 Upload files into subfolder a1c28f9 Merge pull request #4470 from stephanritscher/master 9c1fedb add test cases 6184fcd add test cases 0f97564 Merge pull request #4208 from nextcloud/ezaquarii/new-media-player-service d83792e [tx-robot] updated from transifex 9a2fc28 [tx-robot] updated from transifex f10843e daily dev 20190928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2131 and closes #4220.