Skip to content

[stable-3.8] Normalize local target path in auto upload #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 3 commits into from
Oct 1, 2019
Merged

[stable-3.8] Normalize local target path in auto upload #4587

AndyScherzinger merged 3 commits into from
Oct 1, 2019

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 1, 2019

backport of #4470

stephanritscher and others added 3 commits October 1, 2019 09:15
@stephanritscher
Normalize local target path in auto upload
27b45d0 
This closes #2131 and closes #4220.
@tobiasKaminsky
add test cases
6c7b3a0 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
add test cases
ef7be89 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud App 3.8.1 milestone Oct 1, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 1, 2019
Merged
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Oct 1, 2019

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11039.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Oct 1, 2019

Lint

Typestable-3.8PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

SpotBugs (stable-3.8)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

@AndyScherzinger AndyScherzinger merged commit 426d03d into stable-3.8 Oct 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/4470/stable-3.8 branch October 1, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud App 3.8.1

Development

Successfully merging this pull request may close these issues.

5 participants

@nextcloud-android-bot @tobiasKaminsky @AndyScherzinger @stephanritscher