Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #4577

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.8PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

SpotBugs (stable-3.8)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #4594 into stable-3.8 will increase coverage by 0.02%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             stable-3.8    #4594      +/-   ##
================================================
+ Coverage         16.99%   17.01%   +0.02%     
  Complexity            1        1              
================================================
  Files               361      361              
  Lines             32000    32001       +1     
  Branches           4511     4512       +1     
================================================
+ Hits               5438     5445       +7     
+ Misses            25659    25652       -7     
- Partials            903      904       +1
Impacted Files Coverage Δ Complexity Δ
...cloud/android/ui/preview/PreviewMediaFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 19.64% <0%> (-0.08%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (ø) 0% <0%> (ø) ⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java 29.63% <0%> (+0.19%) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 35.58% <0%> (+0.54%) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 51.57% <0%> (+1.57%) 0% <0%> (ø) ⬇️

Fragment can be detached before async task finishes.
Detached fragment has no context and getString() fails with NPE.

Fixes #4412

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky force-pushed the backport/4577/stable-3.8 branch from 8eb4823 to 7ef8981 Compare October 2, 2019 07:15
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11070.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud nextcloud deleted a comment Oct 2, 2019
@nextcloud nextcloud deleted a comment Oct 2, 2019
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.8PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

SpotBugs (stable-3.8)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

@AndyScherzinger AndyScherzinger merged commit 8c16497 into stable-3.8 Oct 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/4577/stable-3.8 branch October 2, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants