Fix NPE in PreviewMediaFragment

[ezaquarii]

Fragment can be detached when async task finishes.
Detached fragment has no context and getString() fails with NPE.

Fixes #4582

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

[ezaquarii]

@tobiasKaminsky @AndyScherzinger
It will be fixed by #4208, but this little fix should go into 3.8 IMO.

[AndyScherzinger]

/backport to stable-3.8

[tobiasKaminsky]

Thanks for the finding!

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11062.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

273

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	139
Total	427

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	139
Total	427

[codecov]

Codecov Report

Merging #4577 into master will increase coverage by 0.2%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             master   #4577     +/-   ##
==========================================
+ Coverage     16.99%   17.2%   +0.2%     
  Complexity        3       3             
==========================================
  Files           365     375     +10     
  Lines         32093   33424   +1331     
  Branches       4519    4902    +383     
==========================================
+ Hits           5454    5750    +296     
- Misses        25748   26752   +1004     
- Partials        891     922     +31

Impacted Files	Coverage Δ	Complexity Δ
...cloud/android/ui/preview/PreviewMediaFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...c/main/java/com/nextcloud/client/di/AppModule.java	67.44% <0%> (-5.29%)	0% <0%> (ø)
...ncloud/android/datamodel/SyncedFolderProvider.java	10.32% <0%> (-0.89%)	0% <0%> (ø)
...n/java/com/owncloud/android/jobs/FilesSyncJob.java	0% <0%> (ø)	0% <0%> (ø)	⬇️
...a/com/owncloud/android/media/MediaControlView.java	0% <0%> (ø)	0% <0%> (ø)	⬇️
...n/java/com/nextcloud/client/media/PlayerService.kt	0% <0%> (ø)	0% <0%> (?)
...a/com/nextcloud/client/media/PlayerStateMachine.kt	95.31% <0%> (ø)	0% <0%> (?)
...ain/java/com/nextcloud/client/media/ErrorFormat.kt	0% <0%> (ø)	0% <0%> (?)
...in/java/com/nextcloud/client/media/PlaylistItem.kt	0% <0%> (ø)	0% <0%> (?)
... and 11 more

[backportbot-nextcloud]

backport to stable-3.8 in #4594