Bump detekt-gradle-plugin from 1.0.0-RC14 to 1.0.1

[dependabot-preview]

Bumps detekt-gradle-plugin from 1.0.0-RC14 to 1.0.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @AndyScherzinger.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Pull request limits (per update run and/or open at any time)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

[tobiasKaminsky]

All detekt warnings seem to be valid, so we should tackle them here before merging, @ezaquarii, @fogninid

I suggest to just push a commit in this PR.

[AndyScherzinger]

@tobiasKaminsky Well as for the magic numbers in the test cases we can probably live with. Question is do we want to scan the test code too. (In the long run I vote for also having static code analysis for the test code)

[tobiasKaminsky]

Question is do we want to scan the test code too

We should. And also we then should start fixing the problems now, as otherwise the count will increase and it is too much work to get it done again.

Regarding the numbers, e.g. it took me a while to find out why it is set to 42. So this should be changed for readability.

[codecov]

Codecov Report

Merging #4415 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4415      +/-   ##
============================================
- Coverage     17.36%   17.25%   -0.11%     
  Complexity        3        3              
============================================
  Files           373      373              
  Lines         32075    32074       -1     
  Branches       4538     4538              
============================================
- Hits           5569     5534      -35     
- Misses        25598    25637      +39     
+ Partials        908      903       -5

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/com/nextcloud/client/media/Player.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...com/owncloud/android/jobs/NContentObserverJob.java	0% <0%> (-53.34%)	0% <0%> (ø)
...va/com/owncloud/android/ui/SquareLinearLayout.java	0% <0%> (-50%)	0% <0%> (ø)
.../owncloud/android/datamodel/MediaFoldersModel.java	0% <0%> (-20%)	0% <0%> (ø)
...wncloud/android/jobs/MediaFoldersDetectionJob.java	10% <0%> (-9%)	0% <0%> (ø)
...ncloud/android/datamodel/SyncedFolderProvider.java	11.2% <0%> (-4.32%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (-1.2%)	0% <0%> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java	53.79% <0%> (-0.64%)	0% <0%> (ø)
src/main/java/com/owncloud/android/MainApp.java	56.44% <0%> (-0.62%)	0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java	25.3% <0%> (-0.28%)	0% <0%> (ø)
... and 5 more

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11035.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

272

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	139
Total	427

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	139
Total	427

[dependabot-preview]

One of your CI runs failed on this pull request, so Dependabot won't merge it.

• codecov/patch

Dependabot will still automatically merge this pull request if you amend it and your tests pass.