Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Fix #4504

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11077.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

432

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings139
Total427

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings139
Total427

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4f15e87). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4597   +/-   ##
=========================================
  Coverage          ?   17.27%           
  Complexity        ?        3           
=========================================
  Files             ?      373           
  Lines             ?    32079           
  Branches          ?     4539           
=========================================
  Hits              ?     5541           
  Misses            ?    25635           
  Partials          ?      903

@tobiasKaminsky tobiasKaminsky merged commit c9e9fe1 into master Oct 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the buildAgain branch October 2, 2019 11:32
tobiasKaminsky added a commit that referenced this pull request Oct 3, 2019
59e1f7f Merge pull request #4357 from nextcloud/changeDroneOrder
c9e9fe1 Merge pull request #4597 from nextcloud/buildAgain
7ebc88d make build run again
4f15e87 Merge pull request #4592 from nextcloud/parentCheck
b204db0 Merge pull request #4577 from nextcloud/ezaquarii/fix-npe-in-preview-media-fragment
9876c49 Merge pull request #4415 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.0.1
9a580b3 Merge pull request #4591 from nextcloud/dependabot/gradle/org.mockito-mockito-core-3.1.0
f6e24eb if parent is null, then do a regular check, no early exit
0dfdc6a Bump mockito-core from 3.0.0 to 3.1.0
9133158 [tx-robot] updated from transifex
7d8474e daily dev 20191002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't build using new install of Ubuntu 18.04

4 participants