Improve menu file name pattern

[AndyScherzinger]

Resolves #4774

• correcting all menu file names and
• adding the corresponding guidelines chapter to CONTRIBUTING.md including a reference to the original Ribot guidelines.

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11520

[codecov]

Codecov Report

Merging #4789 into master will decrease coverage by 0.04%.
The diff coverage is 9.09%.

@@             Coverage Diff              @@
##             master    #4789      +/-   ##
============================================
- Coverage     17.57%   17.52%   -0.05%     
  Complexity        3        3              
============================================
  Files           377      377              
  Lines         32403    32400       -3     
  Branches       4572     4572              
============================================
- Hits           5694     5678      -16     
- Misses        25799    25803       +4     
- Partials        910      919       +9

Impacted Files	Coverage Δ	Complexity Δ
...ncloud/android/ui/activity/UploadListActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...extcloud/client/errorhandling/ShowErrorActivity.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...i/fragment/contactsbackup/ContactListFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/preview/PreviewTextFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/trashbin/TrashbinActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/activity/UserInfoActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...cloud/android/ui/preview/PreviewMediaFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...m/owncloud/android/ui/adapter/UserListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/fragment/FileDetailFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
... and 15 more

[tobiasKaminsky]

Some smaller changes

[AndyScherzinger]

@tobiasKaminsky please re-review. All requested changed have been done 😃 Thanks for the review ❤️

All changes have been made as per request

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11605

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11607.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

469

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423