Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.9

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11650.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

306

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #4841 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4841      +/-   ##
============================================
+ Coverage     17.58%   17.58%   +<.01%     
  Complexity        3        3              
============================================
  Files           377      377              
  Lines         32403    32403              
  Branches       4581     4581              
============================================
+ Hits           5697     5699       +2     
+ Misses        25790    25784       -6     
- Partials        916      920       +4
Impacted Files Coverage Δ Complexity Δ
.../android/authentication/AuthenticatorActivity.java 1.81% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 50% <0%> (-1.58%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 23.62% <0%> (-1.27%) 0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.57% <0%> (-0.41%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 22.79% <0%> (+0.56%) 0% <0%> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 20.72% <0%> (+0.8%) 0% <0%> (ø) ⬇️

@tobiasKaminsky tobiasKaminsky merged commit 77b6b17 into master Nov 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the disableOldLoginMethod branch November 18, 2019 12:51
@backportbot-nextcloud
Copy link

backport to stable-3.9 in #4850

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Nov 18, 2019
tobiasKaminsky added a commit that referenced this pull request Nov 19, 2019
dbe12e6 Merge pull request #4789 from nextcloud/name_pattern_menus
77b6b17 Merge pull request #4841 from nextcloud/disableOldLoginMethod
b561f68 allow to switch off old login method
b59d96a [tx-robot] updated from transifex
9ae5507 [tx-robot] updated from transifex
bfdaba8 [tx-robot] updated from transifex
c82c080 daily dev 20191116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants