Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 14, 2019

Bumps screengrab from 1.2.0 to 2.0.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @tobiasKaminsky.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Nov 14, 2019
@AndyScherzinger
Copy link
Member

Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller than version 18 declared in library [tools.fastlane:screengrab:2.0.0]

Needs sdk v18, so to be postponed until 3.12

Bumps screengrab from 1.2.0 to 2.0.0.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/tools.fastlane-screengrab-2.0.0 branch from 59bb803 to 10a667b Compare December 19, 2019 06:43
@tobiasKaminsky
Copy link
Member

Needs sdk v18, so to be postponed until 3.12

As this is only for creating screenshots, and we do this only via tests, and I run them on latest Android, we can add an exception.
I'll take care of this.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12058.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

329

Lint

TypemasterPR
Warnings7373
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings136
Total409

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings136
Total409

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #4829 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4829      +/-   ##
============================================
- Coverage     17.94%   17.91%   -0.03%     
  Complexity        3        3              
============================================
  Files           385      385              
  Lines         32679    32679              
  Branches       4594     4594              
============================================
- Hits           5864     5856       -8     
- Misses        25872    25881       +9     
+ Partials        943      942       -1
Impacted Files Coverage Δ Complexity Δ
...m/owncloud/android/ui/activity/DrawerActivity.java 43.16% <0%> (-2.31%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 49.41% <0%> (-1.56%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 25.81% <0%> (-0.51%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.52% <0%> (+0.32%) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 34.67% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java 30.43% <0%> (+0.37%) 0% <0%> (ø) ⬇️
...oud/android/operations/RefreshFolderOperation.java 57.39% <0%> (+0.43%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 25.73% <0%> (+0.84%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (+1.19%) 0% <0%> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderByName.java 17.14% <0%> (+2.85%) 0% <0%> (ø) ⬇️

@dependabot-preview dependabot-preview bot merged commit d231370 into master Dec 19, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/gradle/tools.fastlane-screengrab-2.0.0 branch December 19, 2019 08:00
tobiasKaminsky added a commit that referenced this pull request Dec 20, 2019
6af9523 Merge pull request #4890 from nextcloud/directEditing
b4c3a7d Merge pull request #5018 from grote/thumbnail-fix
b207671 fix during CI
d231370 Merge pull request #4829 from nextcloud/dependabot/gradle/tools.fastlane-screengrab-2.0.0
0d84a2d warning about used feature in newer SDK
b4ea014 use master branch
ec2cfef Direct editing support - abstract EditorWebView - support direct editing endpoint
f2627a2 enable caching
ddffaf7 use custom user agent for onlyOffice
0178499 remove unneeded static string
f25127d revert to master snapshot
95afe8c use editor id to use any editor
d05de98 use file path as parameter for open direct editing file
300abba make sure TextEditor is also only used ond >= Android 5, due to security reason of javascript interface
994817c get direct editing info from endpoint
b31cee5 prevent NPE
d1611f6 Direct editing support - abstract EditorWebView - support direct editing endpoint
516c464 override minSDK for lib
10a667b Bump screengrab from 1.2.0 to 2.0.0
9fbedb4 Merge pull request #4992 from nextcloud/uiComparison
751301c daily dev 20191219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants