Ui comparison

[tobiasKaminsky]

We can record tests with screenshots:

And later we can compare them:

And if it fails, it should get uploaded:

@AndyScherzinger @ezaquarii I appreciate your feedback

[AndyScherzinger]

Like the idea 👍

[nextcloud-android-bot]

Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11978-Screenshot

[codecov]

Codecov Report

Merging #4992 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #4992      +/-   ##
===========================================
+ Coverage     17.55%   17.9%   +0.34%     
  Complexity        3       3              
===========================================
  Files           385     385              
  Lines         32675   32679       +4     
  Branches       4593    4594       +1     
===========================================
+ Hits           5737    5852     +115     
+ Misses        26008   25881     -127     
- Partials        930     946      +16

Impacted Files	Coverage Δ	Complexity Δ
...om/owncloud/android/utils/FileSortOrderByName.java	14.28% <0%> (-2.86%)	0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java	63.96% <0%> (-1.36%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (-1.2%)	0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java	24.89% <0%> (-0.85%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	33.75% <0%> (-0.55%)	0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java	56.95% <0%> (-0.44%)	0% <0%> (ø)
.../android/authentication/AuthenticatorActivity.java	1.81% <0%> (-0.01%)	0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	20.2% <0%> (+0.08%)	0% <0%> (ø)	⬇️
...owncloud/android/ui/activity/SettingsActivity.java	39.57% <0%> (+0.19%)	0% <0%> (ø)	⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java	25.85% <0%> (+0.27%)	0% <0%> (ø)	⬇️
... and 10 more

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11983.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

328

Lint

Type	master	PR
Warnings	73	73
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409