Dark mode: light, dark, follow system #4922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Dec 3, 2019
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11828 |
| getDelegate().applyDayNight(); | ||
| if (AppCompatDelegate.getDefaultNightMode() != AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM) { | ||
|
|
||
| getDelegate().setLocalNightMode("MODE_NIGHT_YES".equals(preferences.getDarkThemeMode()) ? |
Member
There was a problem hiding this comment.
"MODE_NIGHT_YES" should be a constant
tobiasKaminsky
force-pushed
the
themeFollowOS
branch
from
0d83ead to
cfe96e2
Compare
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11838 |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
themeFollowOS
branch
from
cfe96e2 to
5e687f2
Compare
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11839.apk |
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11839 |
Collaborator
|
Issues
======
+ Solved 3
See the complete overview on Codacy |
Collaborator
Codacy332Lint
SpotBugs (new)
SpotBugs (master)
|
Member
Author
|
CI fail is unrelated |
tobiasKaminsky
added a commit
that referenced
this pull request
Dec 5, 2019
adbc1f2 Merge pull request #4940 from nextcloud/changelog-master-stable-3.9.1 e0ec1c1 Add changelog for 3.9.1 9dcb915 [tx-robot] updated from transifex 92510cb Merge pull request #4938 from nextcloud/disableMissingDefaultResource a894814 disable MissingDefaultResource dda56de Merge pull request #4933 from nextcloud/appLocking cb00677 Merge pull request #4926 from nextcloud/deleteChecksFor16 fd48163 Merge pull request #4922 from nextcloud/themeFollowOS 5e687f2 Dark mode: light, dark, follow system fb69c1b remove all checks for <= JELLY_BEAN as we have this as our new minimum. 683faab [tx-robot] updated from transifex c3eec47 daily dev 20191204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4757
Somehow I totally forgot to push this… 🙈
Signed-off-by: tobiasKaminsky tobias@kaminsky.me