remove all checks for <= JELLY_BEAN as we have this as our new minimum. #4926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (view instanceof ViewGroup && Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) { | ||
| findSwitch((ViewGroup) view); | ||
| } | ||
| findSwitch((ViewGroup) view); |
Member
There was a problem hiding this comment.
if (view instanceof ViewGroup) would still be valid, no?
| } | ||
|
|
||
| @Test | ||
| fun `battery charging status on API 14-16`() { |
Member
There was a problem hiding this comment.
We are targeting >= 16 so the tests are still valid, since we still support 16 (!)
Member
|
@tobiasKaminsky just 2 minor comments (which need fixing imho) |
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11832 |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
deleteChecksFor16
branch
from
58d7aab to
fb69c1b
Compare
Member
Author
|
@AndyScherzinger I changed both, thanks for finding them :-) |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11837.apk |
Collaborator
Codacy332Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #4926 +/- ##
============================================
+ Coverage 17.73% 17.74% +0.01%
Complexity 3 3
============================================
Files 384 384
Lines 32650 32640 -10
Branches 4597 4589 -8
============================================
+ Hits 5789 5793 +4
+ Misses 25938 25926 -12
+ Partials 923 921 -2
|
Collaborator
|
Complexity decreasing per file
==============================
+ src/main/java/com/nextcloud/client/onboarding/WhatsNewActivity.java -1
See the complete overview on Codacy |
AndyScherzinger
approved these changes
Dec 4, 2019
tobiasKaminsky
added a commit
that referenced
this pull request
Dec 5, 2019
adbc1f2 Merge pull request #4940 from nextcloud/changelog-master-stable-3.9.1 e0ec1c1 Add changelog for 3.9.1 9dcb915 [tx-robot] updated from transifex 92510cb Merge pull request #4938 from nextcloud/disableMissingDefaultResource a894814 disable MissingDefaultResource dda56de Merge pull request #4933 from nextcloud/appLocking cb00677 Merge pull request #4926 from nextcloud/deleteChecksFor16 fd48163 Merge pull request #4922 from nextcloud/themeFollowOS 5e687f2 Dark mode: light, dark, follow system fb69c1b remove all checks for <= JELLY_BEAN as we have this as our new minimum. 683faab [tx-robot] updated from transifex c3eec47 daily dev 20191204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me