Fix white header with dark mode

[tobiasKaminsky]

Fix #4754

White background of header will not be changed, as this is desired via theming api.
But at least we can now see the text again ;-)

(also applies for all other activities)

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12146.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

329

Lint

Type	master	PR
Warnings	74	74
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	71
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	138
Total	412

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	71
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	138
Total	412

[codecov]

Codecov Report

Merging #5107 into master will decrease coverage by <.01%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##             master    #5107      +/-   ##
============================================
- Coverage     17.79%   17.78%   -0.01%     
  Complexity        3        3              
============================================
  Files           389      389              
  Lines         32890    32893       +3     
  Branches       4626     4627       +1     
============================================
- Hits           5852     5850       -2     
- Misses        26082    26087       +5     
  Partials        956      956

Impacted Files	Coverage Δ	Complexity Δ
...owncloud/android/ui/activity/SettingsActivity.java	39.57% <100%> (ø)	0 <0> (ø)	⬇️
.../owncloud/android/ui/activity/ToolbarActivity.java	63.76% <100%> (ø)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java	49.23% <42.85%> (-1.75%)	0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java	45.17% <66.66%> (ø)	0 <0> (ø)	⬇️
.../third_parties/daveKoeller/AlphanumComparator.java	83.33% <0%> (+1.19%)	0% <0%> (ø)	⬇️

[AndyScherzinger]

@tobiasKaminsky I tried the latest QA build but it renders the "+" on the fab button in white (for dark) so I can see the icon (which seems to work according to your screenshots).

[tobiasKaminsky]

@tobiasKaminsky I tried the latest QA build but it renders the "+" on the fab button in white (for dark) so I can see the icon (which seems to work according to your screenshots).

can you open up a new issue for this? Also which primary color do you use?

[AndyScherzinger]

Done: #5110