Skip to content

spinner: if primary color is white, use grey #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Jan 8, 2020
Merged

spinner: if primary color is white, use grey #5120

AndyScherzinger merged 1 commit into from
Jan 8, 2020

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jan 8, 2020

Fix #5113

As my local setup is lightning fast, I could not grab a screenshot, but maybe you can test the QA build, @AndyScherzinger ?

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
spinner: if primary color is white, use grey
9d2b80d 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Jan 8, 2020

/backport to stable-3.10

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 8, 2020

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12171.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 8, 2020

Codacy

637

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

@codecov
Copy link

codecov bot commented Jan 8, 2020 •
edited
Loading

Codecov Report

Merging #5120 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #5120      +/-   ##
===========================================
+ Coverage     17.65%   17.7%   +0.04%     
  Complexity        3       3              
===========================================
  Files           392     392              
  Lines         33116   33116              
  Branches       4651    4651              
===========================================
+ Hits           5848    5864      +16     
+ Misses        26312   26296      -16     
  Partials        956     956
Impacted Files Coverage Δ Complexity Δ
...loud/android/ui/fragment/ExtendedListFragment.java 52.45% <100%> (ø) 0 <0> (ø) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 25.81% <0%> (-0.51%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 58.94% <0%> (-0.41%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 28.28% <0%> (+0.18%) 0% <0%> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 20.44% <0%> (+0.31%) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 32.84% <0%> (+1.09%) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 50.76% <0%> (+1.53%) 0% <0%> (ø) ⬇️
...ain/java/com/owncloud/android/ui/TextDrawable.java 81.48% <0%> (+7.4%) 0% <0%> (ø) ⬇️
...d/android/operations/GetCapabilitiesOperation.java 87.5% <0%> (+12.5%) 0% <0%> (ø) ⬇️
...m/nextcloud/client/account/UserAccountManager.java 33.33% <0%> (+33.33%) 0% <0%> (ø) ⬇️

AndyScherzinger
AndyScherzinger approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 👍

@AndyScherzinger AndyScherzinger merged commit 8751c85 into master Jan 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the spinner branch January 8, 2020 14:30
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.11.0 milestone Jan 8, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 8, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 8, 2020

backport to stable-3.10 in #5125

tobiasKaminsky added a commit that referenced this pull request Jan 9, 2020
@tobiasKaminsky
daily dev 20200109
e0beda8 
8751c85 Merge pull request #5120 from nextcloud/spinner
9d2b80d spinner: if primary color is white, use grey
de269b2 Merge pull request #5115 from nextcloud/311bump
3baa9fe Merge pull request #5118 from nextcloud/fastlane
ee6e7ce fix fastlane RC
1343ba0 Merge pull request #5114 from nextcloud/richWorkspaceFixes
1ec8b06 - fix not clickable rich workspace area - fix crash on first loading
62aaed7 bump to 3.11 alpha
9a47a4d Merge pull request #5107 from nextcloud/whiteHeader
6cb0f10 Merge pull request #4915 from nextcloud/createText
3011097 [tx-robot] updated from transifex
248fe1a daily dev 20200108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.11.0

Development

Successfully merging this pull request may close these issues.

Spinner is white for light theme and #FFFFFF as primary color

4 participants

@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger