Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #5120

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12178.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 141ed4a into stable-3.10 Jan 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the backport/5120/stable-3.10 branch January 8, 2020 15:45
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.10PR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

SpotBugs (stable-3.10)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #5125 into stable-3.10 will decrease coverage by 0.05%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##             stable-3.10    #5125      +/-   ##
=================================================
- Coverage          17.74%   17.68%   -0.06%     
  Complexity             3        3              
=================================================
  Files                392      392              
  Lines              33116    33116              
  Branches            4651     4651              
=================================================
- Hits                5875     5858      -17     
- Misses             26288    26299      +11     
- Partials             953      959       +6
Impacted Files Coverage Δ Complexity Δ
...loud/android/ui/fragment/ExtendedListFragment.java 52.45% <100%> (ø) 0 <0> (ø) ⬇️
...d/android/operations/GetCapabilitiesOperation.java 75% <0%> (-12.5%) 0% <0%> (ø)
...com/nextcloud/client/logger/LegacyLoggerAdapter.kt 66.66% <0%> (-11.12%) 0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java 64.6% <0%> (-3.1%) 0% <0%> (ø)
...ain/java/com/nextcloud/client/logger/LoggerImpl.kt 86.95% <0%> (-2.9%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 28.28% <0%> (-0.91%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 26.31% <0%> (-0.51%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.12% <0%> (-0.24%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 32.84% <0%> (ø) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (+1.19%) 0% <0%> (ø) ⬇️
... and 2 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants