Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

…] cannot be cast to java.lang.Void[]

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

This is unfortunately too complex to test it in an easy way…

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #5414 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #5414      +/-   ##
============================================
- Coverage     19.88%   19.81%   -0.07%     
  Complexity        3        3              
============================================
  Files           394      394              
  Lines         33210    33210              
  Branches       4666     4666              
============================================
- Hits           6603     6582      -21     
- Misses        25524    25543      +19     
- Partials       1083     1085       +2
Impacted Files Coverage Δ Complexity Δ
...i/fragment/contactsbackup/ContactListFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/nextcloud/client/account/UserAccountManager.java 0% <0%> (-33.34%) 0% <0%> (ø)
...d/android/operations/GetCapabilitiesOperation.java 75% <0%> (-12.5%) 0% <0%> (ø)
...ain/java/com/owncloud/android/ui/TextDrawable.java 74.07% <0%> (-7.41%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 55.28% <0%> (-4.07%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0%> (-1.2%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 32.67% <0%> (-0.55%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 25.81% <0%> (-0.51%) 0% <0%> (ø)
...ava/com/owncloud/android/files/FileMenuFilter.java 53.27% <0%> (-0.44%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 52.69% <0%> (-0.39%) 0% <0%> (ø)
... and 1 more

@AndyScherzinger
Copy link
Member

@tobiasKaminsky lint score need to be raised (nothing we can do about it)

…] cannot be cast to java.lang.Void[]

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12616.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Codacy

337

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings79
Security Warnings45
Dodgy code Warnings138
Total386

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings79
Security Warnings45
Dodgy code Warnings138
Total386

@tobiasKaminsky tobiasKaminsky merged commit 2d6e73d into master Feb 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the fixContactCrash branch February 10, 2020 08:18
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.11.0 milestone Feb 10, 2020
tobiasKaminsky added a commit that referenced this pull request Feb 11, 2020
92ddf10 Merge remote-tracking branch 'origin/master' into dev
5905b1c Merge pull request #5432 from nextcloud/ezaquarii/migrate-drawer-menu-utils-to-new-user-model
4be18ad Merge pull request #5064 from nextcloud/ezaquarii/extract-account-logic-from-base-activity-into-mixin
619b5d0 Merge pull request #5419 from nextcloud/dependabot/gradle/org.projectlombok-lombok-1.18.12
2d6e73d Merge pull request #5414 from nextcloud/fixContactCrash
1bb04aa also increase annotationProcessor
6048243 Fix crash: Caused by: java.lang.ClassCastException: java.lang.Object[] cannot be cast to java.lang.Void[]
0027df9 [tx-robot] updated from transifex
6dd5d92 Merge pull request #5443 from nextcloud/fixTransifex
b4db9d0 do not break line on transifex
b5fb9c1 Migrate drawer menu utilities to new user model
a906a14 daily dev 20200208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants