Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 7, 2020

Bumps lombok from 1.18.10 to 1.18.12.

Changelog

Sourced from lombok's changelog.

v1.18.12 (February 1st, 2020)

  • PLATFORM: Support for JDK13 (including yield in switch expressions, as well as delombok having a nicer style for arrow-style switch blocks, and text blocks).
  • PLATFORM: Support for JDK14 (including pattern match instanceof expressions).
  • FEATURE: In lombok.config it is possible to import other config files, even from a .zip or .jar.
  • FEATURE: You can now configure a builder's 'setter' prefixes via @Builder(setterPrefix = "set") for example. We discourage doing this, but if some library you use requires them, have at it. [Pull Request #2174](rzwitserloot/lombok#2174, [Issue #1805](rzwitserloot/lombok#1805).
  • FEATURE: If you use @Builder's @Singular, a plural form is also generated, which has the effect of adding all elements in the passed collection. If you pass a null reference, this would result in a message-less NullPointerException. Now, it results in that exception but with a useful message attached (uses the same config as @NonNull), or alternatively via a parameter on @Singular, you can choose to ignore such a call (add nothing, return immediately); this can be useful when deserializing (e.g. Jackson JSON) and JPA/Hibernate code. [Issue #2221](rzwitserloot/lombok#2221. singular documentation.
  • FEATURE: Tired of being unable to use @javax.annotation.ParametersAreNonnullByDefault or @org.eclipse.jdt.annotation.NonNullByDefault because then the equals method that lombok generates isn't valid? Fret no more; lombok can now add nullity annotations where relevant. Set the flavour of nullity annotation you prefer in your lombok.config. Applies to the return value of toString, withX, chainable setX, static constructors, build, builder, etcetera, and the parameter of equals, canEqual, and the plural form of @Singular marked fields for builder classes. [Issue #788](rzwitserloot/lombok#788)
  • BUGFIX: If using the sonarlint plugin in eclipse for projects bound to sonarcloud, you now no longer get internal errors on sonarlint processing. [Issue #2351](rzwitserloot/lombok#2351)
  • BUGFIX: lombok.experimental.Wither has been deprecated (it has been renamed to lombok.With). However, the intent is that lombok still handles the old annotation in case you haven't updated your lombok dep yet. However, only a star import on lombok.experimental.* worked; an explicit one would cause lombok to not generate any with method. [Issue #2235](rzwitserloot/lombok#2235)
  • BUGFIX: Referring to an inner class inside the generics on a class marked with @SuperBuilder would cause the error wrong number of type arguments; required 3 [Issue #2262](rzwitserloot/lombok#2262); fixed by github user @Lekanich - thank you!
  • BUGFIX: Some of the code generated by @Builder did not include this. prefixes when accessing fields. While semantically it didn't matter, if you use the 'add this prefix for field accesses' save action in eclipse, the save action would break. [Issue #2327](rzwitserloot/lombok#2327)
  • BUGFIX: When lombok copies javadoc from fields to relevant methods, it should generate an appropriate @return this line if lombok copies the javadoc to a generated setter that is chainable (returns itself). It didn't do that when generating the 'setters' in a @Builder. Lombok also didn't generate an appropriate @return item for @With methods. The javadoc has also been updated slightly (the this reference in the javadoc is now rendered in a code tag).[Issue #2323](rzwitserloot/lombok#2323)
  • IMPROBABLE BREAKING CHANGE: Lombok now generates qualified types (so, Outer.Inner instead of just Inner) in most type signatures that it generates; this should avoid exotic scenarios where the types lombok puts in signatures end up referring to unintended other types, which can occur if your class implements an interface that itself defines a type with the same name as one defined in your source file. I told you it was exotic. Thanks to Hunter Anderson for doing some preliminary work on this change. [Issue #2268](rzwitserloot/lombok#2268)
  • IMPROBABLE BREAKING CHANGE: Running java -jar lombok.jar config -v <files> no longer shows which files do not mention the specified keys. Use --non-mentioned or -n to show them anyway.
Commits
  • 4ca9ccf pre-release version bump
  • 8c952fa [trivial] we've decided to call this one 1.18.12, not 1.20.0.
  • 8943b49 [fixes #880] get rid of an unchecked cast warning for @Getter(lazy=true)
  • 2e06cb3 #2355 fixed tests for clashes in the generics for superbuilder
  • f12b705 [issue #1197] fixed documentation of NonNull
  • 680d63e Merge pull request #2355 from janrieke/superBuilderAvoidMoreNameClashes
  • 4a34ed7 avoid more name clashes for builder type param; fixes #2297
  • a678e7e [issue #1956] make 'ant intellij' work again
  • e229377 [fixing #2351] Reflecting the fix in the changelog.
  • 3f0fec1 [issue #788] Add more nullity annotations where relevant
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @tobiasKaminsky.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Feb 7, 2020
@tobiasKaminsky
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/org.projectlombok-lombok-1.18.12 branch from bd2b7cc to a114080 Compare February 7, 2020 08:58
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/org.projectlombok-lombok-1.18.12 branch from 325d8f3 to 1bb04aa Compare February 10, 2020 07:49
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #5419 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #5419      +/-   ##
===========================================
+ Coverage     19.82%   19.9%   +0.08%     
  Complexity        3       3              
===========================================
  Files           394     394              
  Lines         33210   33210              
  Branches       4666    4666              
===========================================
+ Hits           6583    6610      +27     
+ Misses        25547   25518      -29     
- Partials       1080    1082       +2
Impacted Files Coverage Δ Complexity Δ
...oud/android/operations/RefreshFolderOperation.java 59.34% <0%> (-1.63%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 25.81% <0%> (-1.01%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 24% <0%> (+0.79%) 0% <0%> (ø) ⬇️
...com/owncloud/android/ui/activity/FileActivity.java 27.54% <0%> (+1.13%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 83.33% <0%> (+1.19%) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java 68.58% <0%> (+1.76%) 0% <0%> (ø) ⬇️
...xtcloud/client/preferences/AppPreferencesImpl.java 53.51% <0%> (+2.7%) 0% <0%> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderByName.java 17.14% <0%> (+2.85%) 0% <0%> (ø) ⬇️
...ain/java/com/nextcloud/client/logger/LoggerImpl.kt 86.95% <0%> (+2.89%) 0% <0%> (ø) ⬇️
.../services/firebase/NCFirebaseMessagingService.java 7.14% <0%> (+7.14%) 0% <0%> (ø) ⬇️
... and 2 more

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12617.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

337

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings79
Security Warnings45
Dodgy code Warnings139
Total387

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings79
Security Warnings45
Dodgy code Warnings138
Total386

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky merged commit 619b5d0 into master Feb 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the dependabot/gradle/org.projectlombok-lombok-1.18.12 branch February 10, 2020 08:48
tobiasKaminsky added a commit that referenced this pull request Feb 11, 2020
92ddf10 Merge remote-tracking branch 'origin/master' into dev
5905b1c Merge pull request #5432 from nextcloud/ezaquarii/migrate-drawer-menu-utils-to-new-user-model
4be18ad Merge pull request #5064 from nextcloud/ezaquarii/extract-account-logic-from-base-activity-into-mixin
619b5d0 Merge pull request #5419 from nextcloud/dependabot/gradle/org.projectlombok-lombok-1.18.12
2d6e73d Merge pull request #5414 from nextcloud/fixContactCrash
1bb04aa also increase annotationProcessor
6048243 Fix crash: Caused by: java.lang.ClassCastException: java.lang.Object[] cannot be cast to java.lang.Void[]
0027df9 [tx-robot] updated from transifex
6dd5d92 Merge pull request #5443 from nextcloud/fixTransifex
b4db9d0 do not break line on transifex
b5fb9c1 Migrate drawer menu utilities to new user model
a906a14 daily dev 20200208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants