-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix contacts backup job interval #6139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job interval was set in ms, when API requred minutes. Use of invalid time unit resulted in period of ~164 years. This change removes ms interval constants and sets proper contact backup job period. Fixes #6041 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
Collaborator
Author
|
/backport to stable-3.12 |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14130.apk |
Collaborator
Codacy389Lint
SpotBugs (new)
SpotBugs (master)
|
Collaborator
Author
Flaky e2e test. IMO not related. |
AndyScherzinger
approved these changes
May 24, 2020
tobiasKaminsky
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Job interval was set in ms, when API requred minutes.
Use of invalid time unit resulted in period of ~164 years.
This change removes ms interval constants and sets
proper contact backup job period.
Fixes #6041
Signed-off-by: Chris Narkiewicz hello@ezaquarii.com