[stable-3.12] Fix contacts backup job interval #6144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
AndyScherzinger,
ezaquarii and
tobiasKaminsky
Collaborator
|
Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-3.12)
|
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14145-IT |
Job interval was set in ms, when API requred minutes. Use of invalid time unit resulted in period of ~164 years. This change removes ms interval constants and sets proper contact backup job period. Fixes #6041 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com> Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
backport/6139/stable-3.12
branch
from
75c3da3 to
5ff4856
Compare
tobiasKaminsky
approved these changes
May 25, 2020
Member
Resolved :+1 |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14150.apk |
Collaborator
|
Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-3.12)
|
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14150-IT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #6139