Skip to content

Conversation

@vstelmakh
Copy link
Contributor

Resolves #332

image

Copy link
Contributor

@andrey18106 andrey18106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for manual changes to l10n/*.js files? They are being updated automatically via Transifex (https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#adding-translations).

@vstelmakh
Copy link
Contributor Author

Is there any reason for manual changes to l10n/*.js files? They are being updated automatically via Transifex (https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#adding-translations).

Thank you for bringing this to my attention. I had no idea about the update process for the translation files in this project. My intention was simply to improve the translations related to the change for the languages that I understand.

Should I revert the changes I made to the translation files?

Please let me know how I can best proceed to ensure everything remains consistent with the project's workflow.

@bigcat88
Copy link
Member

Should I revert the changes I made to the translation files?

Yes, please, revert the translation changes.

We try to avoid making changes to multiple topics in a single pull request to make them easier to review and keep the commit and discussion history cleaner.

Copy link
Contributor

@andrey18106 andrey18106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested, thanks for the improvements and some refactoring.

@bigcat88 bigcat88 merged commit 9297fbc into nextcloud:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add possibility to edit Deploy daemon configuration

3 participants