-
Notifications
You must be signed in to change notification settings - Fork 16
Add possibility to edit Deploy daemon configuration #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to edit Deploy daemon configuration #338
Conversation
andrey18106
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for manual changes to l10n/*.js files? They are being updated automatically via Transifex (https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#adding-translations).
Thank you for bringing this to my attention. I had no idea about the update process for the translation files in this project. My intention was simply to improve the translations related to the change for the languages that I understand. Should I revert the changes I made to the translation files? Please let me know how I can best proceed to ensure everything remains consistent with the project's workflow. |
Yes, please, revert the translation changes. We try to avoid making changes to multiple topics in a single pull request to make them easier to review and keep the commit and discussion history cleaner. |
andrey18106
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested, thanks for the improvements and some refactoring.
Resolves #332