Skip to content

Conversation

@shoetten
Copy link
Contributor

@shoetten shoetten commented Sep 25, 2022

Summary

This allows stacks only to be dragged by the title, minimizing accidental drag'n'drops. Also the title can not be edited accidentally while dragging the stack. (see #2669 (comment))

As a bonus, stack title edits can now aborted via or clicking away (same as card titles).

If you want me to add some e2e tests, maybe you can provide me with some pointers? To be honest, i'm not very keen on writing drag'n'drop tests, because they often end up flacky, in my experience..

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@shoetten
Copy link
Contributor Author

hey @juliushaertl any chance for a review or anything i can do to speed this along? :) i would like to avoid piling up merge conflicts.

Signed-off-by: Simon Hötten <s+git@hoetten.org>
Signed-off-by: Simon Hötten <s+git@hoetten.org>
Signed-off-by: Simon Hötten <s+git@hoetten.org>
@juliusknorr juliusknorr force-pushed the feature/stack-dragndrop branch from e78b201 to cd5753f Compare November 7, 2022 18:54
@juliusknorr juliusknorr self-requested a review November 7, 2022 18:56
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and work :)

@juliusknorr
Copy link
Member

Thanks a lot for your contribution and sorry for taking so long. I'm fine to merge this without e2e tests as for the dragging part that might indeed be tricky. If you are curious still, some basic tests for the editing and cancel editing behaviour would be highly appreciated. Since we just added cypress recently and do not have a large coverage yet, every addition is welcome there.

You can start the cypress gui locally running against your local development instance with the following command. The only requirement should be to have deck installed and enabled and a admin user with the password admin:

CYPRESS_baseUrl=http://nextcloud.dev.local/index.php npx cypress open

@juliusknorr
Copy link
Member

Let me merge this to move on, as mentioned, if you still would be up for some test case a follow up PR would be highly appreciated :)

@juliusknorr juliusknorr merged commit 6ea0e24 into nextcloud:master Nov 7, 2022
@shoetten shoetten deleted the feature/stack-dragndrop branch November 8, 2022 22:41
@shoetten
Copy link
Contributor Author

@juliushaertl Here we go #4206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve stack drag and drop behavior

2 participants