Skip to content

Conversation

@juliusknorr
Copy link
Member

Implement notification about suggested apps once the admin is logging in for the first time:

image

  • Notifications are only emitted for apps that are not installed
  • Clicking the notification switches directly to the apps management

@jospoortvliet I took the headlines from the website for now, maybe you have some other idea for the description of those items? Also should we add something to indicate that this is a suggestion to install the app?

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@jancborchardt
Copy link
Member

Very cool @juliushaertl! :)

Agree with @karlitschek that at the moment it’s a bit unclear what the notification is trying to tell. Maybe a simple text before would work, like "Install Nextcloud Talk" or "We recommend to install Talk" or something like that?

@MorrisJobke MorrisJobke mentioned this pull request Jul 15, 2019
28 tasks
@juliusknorr
Copy link
Member Author

@jancborchardt Please have a look at the wording, this is what it looks right now:

image

@jancborchardt
Copy link
Member

jancborchardt commented Jul 16, 2019

Looking good! Notes for me for later:

  • Instead of a dash we should use a : like "App recommendation: Nextcloud Contacts"
  • And the notifications text should possibly be flush left with the title (moved a bit right)
  • Double check that the date has proper contrast

@rullzer
Copy link
Member

rullzer commented Jul 16, 2019

  • And the notifications text should possibly be flush left with the title (moved a bit right)
  • Double check that the date has proper contrast

Those we can't control here. That is the general notifcation stuff.

@jancborchardt
Copy link
Member

  • And the notifications text should possibly be flush left with the title (moved a bit right)
  • Double check that the date has proper contrast

Those we can't control here. That is the general notifcation stuff.

Yep, pull request at nextcloud/notifications#382

@jancborchardt
Copy link
Member

Added some wording fixes here too, please check. :)

@juliusknorr
Copy link
Member Author

Sounds good to me 👍

@jancborchardt
Copy link
Member

@MorrisJobke can you re-review? Or is it fine :)

@juliusknorr juliusknorr force-pushed the enh/app-suggestions branch from d46a77a to 7e2d964 Compare July 16, 2019 14:20
juliusknorr and others added 2 commits July 16, 2019 16:21
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@juliusknorr juliusknorr force-pushed the enh/app-suggestions branch from 7e2d964 to a31dd93 Compare July 16, 2019 14:21
@MorrisJobke MorrisJobke merged commit 0ff0d68 into master Jul 16, 2019
@MorrisJobke MorrisJobke deleted the enh/app-suggestions branch July 16, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants