Skip to content

Fix notification body text alignment and text contrast #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Jul 16, 2019
Merged

Fix notification body text alignment and text contrast #382

juliusknorr merged 1 commit into from
Jul 16, 2019

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Jul 16, 2019

  • Notifications text flush left with the title (moved a bit right)
  • Proper contrast for notifications detail text

Before:
Notifications old

After:
Notifications new

Please review @nextcloud/designers

@jancborchardt
Fix notification body text alignment and text contrast
1f1c5e9 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added this to the Nextcloud 17 milestone Jul 16, 2019
@jancborchardt jancborchardt mentioned this pull request Jul 16, 2019
Merged
@juliusknorr juliusknorr merged commit b002ecd into master Jul 16, 2019
@juliusknorr juliusknorr deleted the design/details branch July 16, 2019 12:24
@nickvergessen nickvergessen mentioned this pull request Jul 17, 2019
Closed
@nickvergessen
Copy link
Member

nickvergessen commented Jul 17, 2019

/backport to stable16

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 17, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jul 17, 2019

backport to stable16 in #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees

No one assigned

Labels

3. to review design

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt @nickvergessen @juliusknorr