Skip to content

API v2 #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jotoeri merged 2 commits into from
Jun 3, 2022
Merged

API v2 #1126

jotoeri merged 2 commits into from
Jun 3, 2022

Conversation

@jotoeri
Copy link
Member

@jotoeri jotoeri commented Feb 22, 2022 •
edited
Loading

This is in fact a part of #1087. Splitting this off for easier review.

  • Moving the whole API to v2
  • I first tried to keep API v1.1, however mapping the new sharing to the old way is way too hard for its benefit. Thus - even that not good at all - I'd drop API v1.1. To have at least some 'compatibility' for outside API users, a capabilities response should hint on which API exists on the instance. Include Capabilities Response #1146
  • Adapt API Documentation to changes
  • Add Sharing-Part to API-Doc

@jotoeri jotoeri added high High priority integration Compatibility with other apps/systems 2. developing Work in progress labels Feb 22, 2022
@jotoeri jotoeri self-assigned this Feb 22, 2022
@jotoeri jotoeri mentioned this pull request Feb 22, 2022
Merged
@jotoeri jotoeri force-pushed the fix/apiv2 branch 2 times, most recently from 6e447b4 to 78a4063 Compare March 3, 2022 22:07
@jotoeri jotoeri force-pushed the fix/apiv2 branch 2 times, most recently from a566031 to 97add64 Compare March 22, 2022 21:29
@jotoeri jotoeri added this to the 3.0 milestone Mar 29, 2022
@jotoeri jotoeri force-pushed the fix/apiv2 branch 6 times, most recently from 980a593 to 53ffbce Compare March 29, 2022 18:14
@jotoeri jotoeri marked this pull request as ready for review March 29, 2022 18:16
@jotoeri jotoeri mentioned this pull request Mar 29, 2022
Merged
@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 29, 2022
@jotoeri jotoeri requested review from Chartman123 and skjnldsv March 29, 2022 18:24
This was referenced Apr 4, 2022
Merged
Closed
@jotoeri jotoeri force-pushed the enh/sharing branch 16 times, most recently from c59d102 to e9fe8e3 Compare May 23, 2022 20:16
@jotoeri jotoeri force-pushed the fix/apiv2 branch 3 times, most recently from 170df20 to e042efa Compare May 24, 2022 09:00
jotoeri added 2 commits May 31, 2022 21:41
@jotoeri
Move API to v2
f92c504 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Some basic API tests
e90412e 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Copy link
Member Author

jotoeri commented May 31, 2022

Ok - so @Chartman123 @skjnldsv This should now be a quite simple review, as it is only the first commit to check. The second commit has been done with #1148

Base automatically changed from enh/sharing to master May 31, 2022 19:58
@Chartman123
Copy link
Collaborator

Chartman123 commented May 31, 2022

Ok - so @Chartman123 @skjnldsv This should now be a quite simple review, as it is only the first commit to check. The second commit has been done with #1148

OK, I'll try to find some time to dive into this. :)

Chartman123
Chartman123 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't run the code, but couldn't find any obvious problems by reviewing the code :)

@jotoeri
Copy link
Member Author

jotoeri commented Jun 3, 2022

I tested it quite a few times meanwhile, i think. 😉

@jotoeri jotoeri merged commit 0be3aab into master Jun 3, 2022
@jotoeri jotoeri deleted the fix/apiv2 branch June 3, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chartman123 Chartman123 Chartman123 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@jotoeri jotoeri

Labels

3. to review Waiting for reviews high High priority integration Compatibility with other apps/systems

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jotoeri @Chartman123