Skip to content

Conversation

@jotoeri
Copy link
Member

@jotoeri jotoeri commented Mar 29, 2022

Initially i wrote this test in #1126, now splitting again for easier review.

  • Adding simple API-Querying "Tests". They are by far not complete (in the sense of testing every possibility) and unfortunately not respected by the coverage, but they at least query each API-Request in full depth once, so better than nothing...^^
  • In combination with these tests -> dropping php7.2 to use guzzle, thus also enabling to update to phpunit 9

@jotoeri jotoeri requested a review from skjnldsv March 29, 2022 18:24
@jotoeri jotoeri added 3. to review Waiting for reviews integration Compatibility with other apps/systems labels Mar 29, 2022
@jotoeri jotoeri added this to the 3.0 milestone Apr 4, 2022
@jotoeri jotoeri added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 5, 2022
@jotoeri
Copy link
Member Author

jotoeri commented Apr 5, 2022

Waiting for the big rebase once #1159 is merged.

@skjnldsv
Copy link
Member

skjnldsv commented Apr 7, 2022

/rebase

@skjnldsv
Copy link
Member

skjnldsv commented Apr 7, 2022

I created standards tests for phpunit in our github repo if you want 😉
https://github.com/nextcloud/forms/actions/new?category=owner

image

@jotoeri
Copy link
Member Author

jotoeri commented Apr 7, 2022

!! This one is based on #1087 and #1126, so the last one to merge then... 😉 !!

  • Also reinclude composer.lock again (need my other pc 😉 )

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1148 (6ee2884) into fix/apiv2 (250b414) will decrease coverage by 0.65%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             fix/apiv2    #1148      +/-   ##
===============================================
- Coverage        32.29%   31.64%   -0.66%     
  Complexity         415      415              
===============================================
  Files               38       38              
  Lines             1604     1637      +33     
===============================================
  Hits               518      518              
- Misses            1086     1119      +33     

@jotoeri jotoeri force-pushed the fix/apiv2 branch 2 times, most recently from 4a491a8 to 250b414 Compare April 8, 2022 11:43
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 8, 2022
@skjnldsv skjnldsv merged commit 602db19 into fix/apiv2 Apr 12, 2022
@skjnldsv skjnldsv deleted the enh/api_test branch April 12, 2022 10:14
@jotoeri jotoeri restored the enh/api_test branch May 23, 2022 20:19
@jotoeri jotoeri deleted the enh/api_test branch May 23, 2022 20:19
@jotoeri jotoeri mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews integration Compatibility with other apps/systems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants