Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Conversation

@MorrisJobke
Copy link
Member

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@rullzer
Copy link
Member

rullzer commented Oct 29, 2016

LGTM.
Travis is complaining. Seems they upgraded phpunit

@oparoz
Copy link
Member

oparoz commented Oct 29, 2016

Hmmm... "You" have probably made changes to your test class again in server.

Since there is no dev ML at NC, these sort of changes should be announced in the forums.

@oparoz oparoz merged commit 865662a into master Nov 24, 2016
@oparoz oparoz deleted the dont-use-legacy-OC_L10n branch November 24, 2016 09:24
@MorrisJobke
Copy link
Member Author

Hmmm... "You" have probably made changes to your test class again in server.

Since there is no dev ML at NC, these sort of changes should be announced in the forums.

Looking at @rullzer and @nickvergessen

@nickvergessen
Copy link
Member

No, we fixed the test class to stay compatible

@oparoz
Copy link
Member

oparoz commented Nov 24, 2016

Yes, we sorted it out in the end, but we just have to be careful with such changes as it's unpleasant for app devs to have to fight against problems which come out of nowhere and are out of their hands :)

@nickvergessen
Copy link
Member

Well usually I see such things on my own apps first, so there is always an example how to fix it. ;) I try my best to keep that up and not let it happen again.

@MorrisJobke
Copy link
Member Author

Yes, we sorted it out in the end, but we just have to be careful with such changes as it's unpleasant for app devs to have to fight against problems which come out of nowhere and are out of their hands :)

Out of nowhere? That are private namespace classes - we have everywhere big warnings not to use them. 😉

@nickvergessen
Copy link
Member

Well Test\TestCase is an Exception

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants