Move away from legacy OC_L10N #1948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @nickvergessen and @bartv2 to be potential reviewers. |
Member
|
I will review this and while doing this also fix all the apps in our repo. |
Member
|
We should put this in the release notes ;) |
This was referenced Oct 28, 2016
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
|
Tested and works so far 👍 |
Current coverage is 57.15% (diff: 50.00%)@@ master #1948 diff @@
==========================================
Files 1079 1078 -1
Lines 61585 61551 -34
Methods 6886 6899 +13
Messages 0 0
Branches 0 0
==========================================
- Hits 35242 35179 -63
- Misses 26343 26372 +29
Partials 0 0
|
Member
|
👍 |
Member
|
@rullzer Doc update? Release notes ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was still lying around used in a few places that could (and should) use
\OCP\IL10Netc.CC: @LukasReschke @nickvergessen @MorrisJobke