Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Conversation

@nickvergessen
Copy link
Member

Ref nextcloud/server#2448
Licence: AGPL

@oparoz

@nickvergessen nickvergessen added 3. to review Waiting for reviews bug Something isn't working labels Dec 2, 2016
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Dec 2, 2016
@oparoz
Copy link
Member

oparoz commented Dec 2, 2016

Hold on I thought we had this new way of asking Files to load scripts (loadAdditionalScript or something). Wouldn't that be a better solution?

@nickvergessen
Copy link
Member Author

Yes, if that is enough use that:
https://github.com/nextcloud/files_texteditor/blob/master/appinfo/app.php#L5

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the only-load-scripts-on-files-and-sharing branch from c61f03e to c90564f Compare December 5, 2016 08:37
@nickvergessen
Copy link
Member Author

Updated, for better diff see https://github.com/nextcloud/gallery/pull/181/files?w=1

@codecov-io
Copy link

codecov-io commented Dec 5, 2016

Current coverage is 99.74% (diff: 100%)

Merging #181 into master will decrease coverage by <.01%

@@             master       #181   diff @@
==========================================
  Files            39         39          
  Lines          1201       1197     -4   
  Methods         170        170          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1198       1194     -4   
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update 6bc9e35...a722fac

@oparoz
Copy link
Member

oparoz commented Dec 6, 2016

Thanks for the update, the only thing missing is the same thing for public pages. @rullzer had added it to 10 I think.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

I thought that was the same, but It only has a similar name. Fixed.

@rullzer
Copy link
Member

rullzer commented Dec 8, 2016

Ah yes we can do that now that oC support is gone. 👍

@rullzer rullzer modified the milestones: Nextcloud 12.0, Nextcloud 11.0 Jan 5, 2017
@oparoz oparoz merged commit 65acb05 into master Jan 5, 2017
@oparoz oparoz deleted the only-load-scripts-on-files-and-sharing branch January 5, 2017 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants