only reload on errors when logged in #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @LukasReschke and @nickvergessen to be potential reviewers. |
Member
|
You need to fix the js tests :) |
Member
|
I agree with this fix, but I think the gallery app should be adjusted to be less aggressive as well. Will have a look. 👍 |
Member
|
Tested and works 👍 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
nickvergessen
added
4. to release
This was referenced Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
http://example.com/login?redirect_url=/owncloud/apps/filesThe gallery app will see
apps/filesin the url, think it's in the files app and serve it's script.The gallery scripts will try to load the config trough an ajax call, the ajax call will fail since the user is logged out, the 401 error will be detected and a reload will be scheduled.
This keeps repeating itself over and over again.
Note that this could be fixed in the gallery app (although not trivially since it needs to load it scripts on non logged in public shares) but preventing apps from ever triggering this case seems useful.
This bug is brought to you by running master in production and having parents who can't type in their passwords within 5 seconds.