Use global jQuery for now #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
requested review from
ChristophWurst,
julien-nc,
paulschwoerer and
tacruc
Member
|
Alternatively you can copy https://github.com/nextcloud/server/blob/master/core/src/jquery/requesttoken.js and still use your own jquery |
Collaborator
|
@gary-kim what do you think? |
Member
Author
|
There's a couple other features from core jQuery that's being used so that needs to be changed first so I think it'd be better to postpone that for a little bit. I just really want to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, we still need to use the global jQuery else we get CSRF errors. 😢
Especially since the global jQuery is being deprecated (nextcloud/server#19386), we need to move away from using it ASAP but this is a quick fix so we can get
0.1.5out and fix the unable to unpack issue. Let's switch to using@nextcloud/axiosbefore the release of Nextcloud 19.