Deprecate global jQuery #19386
Merged
Deprecate global jQuery #19386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Upgrading will also be hard. In any case this is a good step! |
rullzer
approved these changes
Feb 10, 2020
Member
Author
Depends. Biggest breaking change I've seen is when the load event ( |
Member
Author
|
We can also announce the upgrade. And if it doesn't work we don't do it. But better to announce and have people migrate away than having to break it short notice. |
juliusknorr
approved these changes
Feb 10, 2020
ChristophWurst
force-pushed
the
techdebt/deprecate-global-jquery
branch
2 times, most recently
from
f015155 to
5526aa7
Compare
rullzer
force-pushed
the
techdebt/deprecate-global-jquery
branch
from
5526aa7 to
c7583c4
Compare
Member
|
/compile amend / |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
techdebt/deprecate-global-jquery
branch
from
c7583c4 to
328f967
Compare
ChristophWurst
added
the
pending documentation
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating away will be hard. But so is updating to v3. As briefly discussed at the last contributor week it's time to deprecate the global variable, at least. This won't be a breaking change but devs can start to think about their migration path, while we also have some time to fix our code.
Maybe this sounds crazy, but what if we announce that jQuery will be upgraded to v3 in Nextcloud 21? This would be a soft-break. Like most scripts will still work. But some might need fine adjustments. And then completely remove the global variable in a later release?
cc @nextcloud/javascript