Use a mixin method for translations #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
|
I'd say it makes sense for now to just keep them as a mixin for your app. We can still package it somehow together with the other frontend components, once we start working on them. |
juliusknorr
approved these changes
Feb 2, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding computed values for all the translations we can use a method.
I added the t and n as wrappers as part of a mixin. Should we do it this way, or does someone want to release this as an npm module which all apps then embed additionally to Vue. I guess we will never change the methods, but otherwise the mixin would be bound to a specific Nextcloud version.
@ChristophWurst @juliushaertl