Skip to content

Read translations from .vue files too #8094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nickvergessen wants to merge 1 commit into from
Closed

Read translations from .vue files too #8094

nickvergessen wants to merge 1 commit into from

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 29, 2018

Don't know how to run the script local. @MorrisJobke to the rescue

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters labels Jan 29, 2018
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Jan 29, 2018
@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 29, 2018

For testing see the empty translation list of the notifications app.

@codecov
Copy link

codecov bot commented Jan 29, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@01482b3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #8094   +/-   ##
========================================
  Coverage          ?   51.7%           
  Complexity        ?   25426           
========================================
  Files             ?    1598           
  Lines             ?   95236           
  Branches          ?    1376           
========================================
  Hits              ?   49244           
  Misses            ?   45992           
  Partials          ?       0

@nickvergessen
Read translations from .vue files too
d1618f1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/read-translations-for-vue-files-too branch from d1d45e4 to d1618f1 Compare January 29, 2018 14:25
@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 29, 2018

Okay, got it working now and confirmed its working.

For extra apps nextcloud/docker-ci#73 is necessary

nickvergessen
nickvergessen commented Jan 29, 2018
View reviewed changes
l10n/l10n.pl
foreach my $i ( @files ){
next if substr( $i, 0, 1 ) eq '.';
next if $i eq 'l10n';
next if $i eq 'node_modules';
Copy link
Member Author

@nickvergessen nickvergessen Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made it skip node_modules by default...

@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 30, 2018 •
edited
Loading

I noticed, that the way I use currently is quite unsatisfying for apps with a lot of strings in the UI:
https://github.com/nextcloud/notifications/blob/b59df847cf8a6fcc906e97496784d8446f8371f1/js-src/components/root.vue#L38-L40

Maybe it's time to write a component for t() and n(), or how did you experience this stuff?
@ChristophWurst @juliushaertl
nextcloud/notifications#114

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 2, 2018

Removed by #6265 -> closing

@nickvergessen nickvergessen deleted the bugfix/noid/read-translations-for-vue-files-too branch February 2, 2018 11:18
@MorrisJobke MorrisJobke removed this from the Nextcloud 14 milestone Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @MorrisJobke