chore: Migrate to vue3 #3174
Open
chore: Migrate to vue3 #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/chore/migrate_to_vue3
branch
from
564186d to
c6735eb
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3174 +/- ##
=========================================
- Coverage 2.23% 1.83% -0.41%
=========================================
Files 107 105 -2
Lines 6519 8500 +1981
Branches 121 123 +2
=========================================
+ Hits 146 156 +10
- Misses 6368 8338 +1970
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
artonge
changed the title
artonge
force-pushed
the
artonge/chore/migrate_to_vue3
branch
2 times, most recently
from
028ebdb to
73197d6
Compare
artonge
force-pushed
the
artonge/chore/migrate_to_vue3
branch
3 times, most recently
from
a447c9a to
9be1c3e
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/chore/migrate_to_vue3
branch
2 times, most recently
from
9f00645 to
e85871b
Compare
It is not compatible with vue3. We can replace it with the internal `VirtualScrolling` component as well as a custom grid layout component. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Prevent vue from converting the Semaphore object to a proxy as this is breaking private property access. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Because NcActions wants direct NcAction* children Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Because NcActions wants direct NcAction* children. And ajax endpoint is deprecated. Signed-off-by: Louis Chemineau <louis@chmn.me>
And distinguish groups from users. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/chore/migrate_to_vue3
branch
from
e85871b to
ad6f7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm lint:fixand fix reported warningsvue,vue-routerandvuexisMobileimportvue-virtual-gridReplaced with the internal virtual scrolling component.vueprovidednextTickfunctionTODO
UploadPicker@nc/vue