Skip to content

chore: Migrate to vue3 #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artonge wants to merge 24 commits into
base: master
Choose a base branch
from
Open

chore: Migrate to vue3 #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
580b6c1
chore: Update dependencies for vue3
artonge Sep 18, 2025
dae498a
chore: Run npm lint:fix and fix reported warnings
artonge Sep 8, 2025
5ee0fe8
refactor: Update usage of vue, vue-router and vuex
artonge Sep 8, 2025
ba09680
chore: Remove unused isMobile import
artonge Sep 9, 2025
a0f6919
refactor: Get rid of vue-virtual-grid
artonge Sep 10, 2025
627cb0d
chore: Modernize router instantiation
artonge Sep 10, 2025
a8e4046
TODO: Use UploadPicker from @nc/vue
artonge Sep 10, 2025
e0da2d8
chore: Do not use Vue method to update objects
artonge Sep 10, 2025
d19b3c9
chore: Use vue provided nextTick function
artonge Sep 10, 2025
631071f
fix: Mark semaphore object as raw
artonge Sep 10, 2025
5398b6d
refactor: Migrate to vue3 lib of leaflet
artonge Sep 18, 2025
fad73c7
fix: Close the sidebar when the viewer is closed
artonge Sep 10, 2025
e1d8406
fix NcCheckbox usage
artonge Sep 10, 2025
5ed9448
fix: Usage of NcTextField
artonge Sep 10, 2025
5a8a22a
fix(AlbumContent): Album's name
artonge Sep 10, 2025
8382f4c
fix: Favorite state toggle
artonge Sep 10, 2025
8f073ba
fix(FileComponent): Ref access
artonge Sep 10, 2025
f5cff0a
fix: Download action
artonge Sep 10, 2025
32c8a0d
fix(Collaborator): Remove legacy @search listener
artonge Sep 11, 2025
33bdc3f
fix(filters): Add padding and prevent overflow of filters display
artonge Sep 17, 2025
e5c778d
fix(filters): Adapte date range picker to the new @nc/vue implementation
artonge Sep 17, 2025
6fdf051
chore: Rationalise translate function import
artonge Sep 18, 2025
55c0ba0
chore: Place licence at the top of some files
artonge Sep 18, 2025
ad6f7f2
chore: Fix some lint warnings
artonge Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cypress/e2e/smart-albums.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ describe('View list of photos in the main timeline', () => {
})

it('Should allow to set filters in the setting dialog and on save', () => {
setDateRangeFilter('2019-01-01 ~ 2019-12-31')
setDateRangeFilter('2019-01-01 - 2019-12-31')
cy.get('[data-test="media"]').should('have.length', 3)

setPlacesFilter(['Lauris'])
cy.get('[data-test="media"]').should('have.length', 1)
})

it('Should display the filters in the setting dialog', () => {
setDateRangeFilter('2019-01-01 ~ 2019-12-31')
setDateRangeFilter('2019-01-01 - 2019-12-31')
setPlacesFilter(['Lauris'])

openAlbumSetting()
Expand All @@ -58,7 +58,7 @@ describe('View list of photos in the main timeline', () => {
})

it('Should keep filters after a refresh', () => {
setDateRangeFilter('2019-01-01 ~ 2019-12-31')
setDateRangeFilter('2019-01-01 - 2019-12-31')
setPlacesFilter(['Lauris'])

cy.get('[data-test="media"]').should('have.length', 1)
Expand Down
5 changes: 4 additions & 1 deletion cypress/e2e/smartAlbumsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ export function setDateRangeFilter(dateRange: string) {
openAlbumSetting()

cy.get('[data-cy-photos-filters-input] input[type="search"]').type('Custom{enter}', { scrollBehavior: 'nearest' })
cy.get('[data-cy-photos-filters-input="custom-date-range"] input[name="date"]').type(`${dateRange}{enter}`, { scrollBehavior: 'nearest' })
cy.get('[data-cy-photos-filters-input="custom-date-range"] input').then(($input) => {
$input.val(dateRange)
$input[0]!.dispatchEvent(new Event('input', { bubbles: true }))
})

cy.intercept({ times: 1, method: 'PROPFIND', url: 'remote.php/dav/photos/*/albums/*' }).as('propfindAlbumContent')
cy.contains('Save').click()
Expand Down
8 changes: 4 additions & 4 deletions cypress/e2e/timelines-filters.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('View list of photos in the main timeline', () => {
})

it('Apply date range filter to timeline', () => {
setDateRangeFilter('2020-01-01 ~ 2020-12-31')
setDateRangeFilter('2020-01-01 - 2020-12-31')
cy.get('[data-test="media"]').should('have.length', 2)

clearFilters(1)
Expand All @@ -52,7 +52,7 @@ describe('View list of photos in the main timeline', () => {
})

it('Apply multiple filters to timeline', () => {
setDateRangeFilter('2019-01-01 ~ 2019-12-31')
setDateRangeFilter('2019-01-01 - 2019-12-31')
cy.get('[data-test="media"]').should('have.length', 3)

setPlacesFilter(['Lauris'])
Expand All @@ -63,14 +63,14 @@ describe('View list of photos in the main timeline', () => {
})

it('Changing view resets filters', () => {
setDateRangeFilter('2020-01-01 ~ 2020-12-31')
setDateRangeFilter('2020-01-01 - 2020-12-31')
cy.get('body').type('{esc}')
navigateToTimeline('photos')
cy.get('[data-test="media"]').should('have.length', 5)
})

it('Should allow to create an album based on the filters', () => {
setDateRangeFilter('2019-01-01 ~ 2019-12-31')
setDateRangeFilter('2019-01-01 - 2019-12-31')
setPlacesFilter(['Lauris'])

cy.get('[data-cy-header-action="create-album"]').click()
Expand Down
5 changes: 4 additions & 1 deletion cypress/e2e/timelinesFiltersUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ export function setDateRangeFilter(dateRange: string) {
cy.intercept({ times: 2, method: 'SEARCH', url: 'remote.php/dav/' }).as('search')

cy.get('[data-cy-photos-filters-input] input[type="search"]').type('Custom{enter}', { scrollBehavior: 'nearest' })
cy.get('[data-cy-photos-filters-input="custom-date-range"] input[name="date"]').type(`${dateRange}{enter}`, { scrollBehavior: 'nearest' })
cy.get('[data-cy-photos-filters-input="custom-date-range"] input').then(($input) => {
$input.val(dateRange)
$input[0]!.dispatchEvent(new Event('input', { bubbles: true }))
})

cy.wait('@search')
}
Expand Down
4 changes: 2 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
* SPDX-License-Identifier: CC0-1.0
*/

import { recommendedVue2 } from '@nextcloud/eslint-config'
import { recommended } from '@nextcloud/eslint-config'

export default [
...recommendedVue2,
...recommended,
{
ignores: [
'js/',
Expand Down
Loading
Loading