Button regressions in 23

[ChristophWurst]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

1. Upgrade to Nextcloud 23 (dev instance)
2. Use Calendar or Mail

Expected behavior

Buttons render the same way as in Nextcloud 22

^ latest and greatest 22 production instance

Actual behavior

^ today's server master

---

This is possibly caused by #25721

cc @GretaD @marcoambrosini

[GretaD]

I cannot reproduce this. Are you sure you were not on my "move new msg into a modal" branch? Because on that branch is broken because its an old one.

@marcoambrosini can you reproduce?

[ChristophWurst]

its an old one.

Right. Latest Mail master looks better. Did we fix this in nc/vue? Calendar is still broken.

the pr was on server. We fixed it on server and mail. So i should do it for calendar too then.

[marcoambrosini]

summary of the problem:
adding the :not(.button-vue) pseudo class makes some rules "more important" than they were before, therefore the rules hierarchy is messed up and this results in potentially many regressions across the apps that rely on this.

On the other hand, afaik this is the only way we can avoid targeting the Vue components with server css.
@skjnldsv what do we do about this?

[raimund-schluessler]

This also happens with server 22.2.3, so not only 23. I guess this is because #29113 never was reverted and 22.2.1 onwards now also ships the new button color variables.

[ChristophWurst]

Right, that solves the mystery of why 22 is suddenly affected as well 🙈