Do not target vue buttons with server rules #25721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
requested review from
ChristophWurst,
GretaD,
julien-nc,
juliusknorr and
skjnldsv
marcoambrosini
added
3. to review
Member
|
Should we probably just use |
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
marcoambrosini
force-pushed
the
do-not-target-vue-buttons
branch
from
06dda84 to
8691084
Compare
Member
Author
|
Done! |
ChristophWurst
approved these changes
Mar 5, 2021
juliusknorr
approved these changes
Mar 5, 2021
juliusknorr
added
4. to release
Member
|
this causes a regression where action menu icons (and text?) shows very faded. Observed in Mail. is this known/intended? |
Member
I guess this needs fixing in the vue components now they are standalone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further exception for vue buttons.
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me