Fix detection of file types a bit #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @rullzer and @tanghus to be potential reviewers |
Member
|
What happens if the media type is not |
Member
Author
|
Well you can use regex to match that So instead of blocking is |
nickvergessen
force-pushed
the
fix-detection-of-file-types-a-bit
branch
from
a5b4df4 to
2d61ee3
Compare
Member
|
I'll add something to the doc. |
Member
Member
|
LGTM |
Member
Author
|
Second +1 so we can do the backport to 10? @MorrisJobke @oparoz @LukasReschke |
Member
|
LGTM |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@icewind1991 Do you have any better idea?
@oparoz @LukasReschke